On 12/15/2017 01:05 PM, Christian König wrote:
I'm in favour of that. But I don't think what I proposed is a step
away from that direction. On the contrary. I've attached a POC patch
with the correctness checks stripped, not compile-tested. Much easier
to follow if you ask me, but if you fee
Am 15.12.2017 um 12:35 schrieb Thomas Hellstrom:
On 12/15/2017 10:53 AM, Christian König wrote:
Well this is more or less replicating what you are doing currently
but instead of spreading the checks and locking state all over the
code, both as local variables and parameters this is keeping it
On 12/15/2017 10:53 AM, Christian König wrote:
Well this is more or less replicating what you are doing currently
but instead of spreading the checks and locking state all over the
code, both as local variables and parameters this is keeping it in a
single place with correctness checks.
I d
Am 15.12.2017 um 10:38 schrieb Thomas Hellstrom:
On 12/15/2017 10:13 AM, Christian König wrote:
Hi Thomas,
actually I was very happy to get rid of that stuff.
Yes, wrappers that don't do anything don't make much sense, but this
is a different story.
I was not talking about the wrappers, bu
On 12/15/2017 10:13 AM, Christian König wrote:
Hi Thomas,
actually I was very happy to get rid of that stuff.
Yes, wrappers that don't do anything don't make much sense, but this is
a different story.
In the long run I indeed wanted to replace ctx->resv with the
ww_acquire_ctx to enable
Am 15.12.2017 um 07:24 schrieb Thomas Hellstrom:
Hi.
On 12/14/2017 09:10 AM, Roger He wrote:
Change-Id: I0c6ece0decd18d30ccc94e5c7ca106d351941c62
Signed-off-by: Roger He
---
drivers/gpu/drm/ttm/ttm_bo.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/
-Original Message-
From: Thomas Hellstrom [mailto:tho...@shipmail.org]
Sent: Friday, December 15, 2017 2:25 PM
To: He, Roger ; amd-...@lists.freedesktop.org;
dri-devel@lists.freedesktop.org
Cc: Koenig, Christian
Subject: Re: [PATCH] drm/ttm: enable eviction for Per-VM-BO
Hi.
On 12/14
Hi Thomas,
actually I was very happy to get rid of that stuff.
In the long run I indeed wanted to replace ctx->resv with the
ww_acquire_ctx to enable eviction of even more things, but that is a
different story.
Recursive locking is usually something we should try to avoid.
Regards,
Christia
Roger and Chrisitian,
Correct me if I'm wrong, but It seems to me like a lot of the recent
changes to ttm_bo.c are to allow recursive reservation object locking in
the case of shared reservation objects, but only in certain functions
and with special arguments so it doesn't look like recursive
Hi.
On 12/14/2017 09:10 AM, Roger He wrote:
Change-Id: I0c6ece0decd18d30ccc94e5c7ca106d351941c62
Signed-off-by: Roger He
---
drivers/gpu/drm/ttm/ttm_bo.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.
We need some commit message here. Something like this:
Allow eviction of BOs reserved by the caller when they are not part of
the current working set.
with that fixed the patch is Reviewed-by: Christian König
.
Thanks,
Christian.
Am 14.12.2017 um 09:10 schrieb Roger He:
Change-Id: I0c6ece
11 matches
Mail list logo
