Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-30 Thread Andi Shyti
Hi Janusz, merged to drm-intel-gt-next. Thanks, Andi On Wed, Jun 11, 2025 at 12:42:13PM +0200, Janusz Krzysztofik wrote: > The following error has been reported sporadically by CI when a test > unbinds the i915 driver on a ring submission platform: > > <4> [239.330153] [ cut here ]-

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-12 Thread Janusz Krzysztofik
On Thursday, 12 June 2025 13:30:42 CEST Andi Shyti wrote: > Hi Janusz, > > On Thu, Jun 12, 2025 at 11:45:46AM +0200, Janusz Krzysztofik wrote: > > On Thursday, 12 June 2025 11:35:31 CEST Jani Nikula wrote: > > > On Thu, 12 Jun 2025, Janusz Krzysztofik > > > wrote: > > > > On Wednesday, 11 June 2

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-12 Thread Andi Shyti
Hi Janusz, On Thu, Jun 12, 2025 at 11:45:46AM +0200, Janusz Krzysztofik wrote: > On Thursday, 12 June 2025 11:35:31 CEST Jani Nikula wrote: > > On Thu, 12 Jun 2025, Janusz Krzysztofik > > wrote: > > > On Wednesday, 11 June 2025 22:54:40 CEST Andi Shyti wrote: > > >> Hi Nitin, > > >> > > >> On W

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-12 Thread Janusz Krzysztofik
On Thursday, 12 June 2025 11:35:31 CEST Jani Nikula wrote: > On Thu, 12 Jun 2025, Janusz Krzysztofik > wrote: > > On Wednesday, 11 June 2025 22:54:40 CEST Andi Shyti wrote: > >> Hi Nitin, > >> > >> On Wed, Jun 11, 2025 at 03:45:30PM +, Gote, Nitin R wrote: > >> > [...] > >> > > Subject: [PAT

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-12 Thread Jani Nikula
On Thu, 12 Jun 2025, Janusz Krzysztofik wrote: > On Wednesday, 11 June 2025 22:54:40 CEST Andi Shyti wrote: >> Hi Nitin, >> >> On Wed, Jun 11, 2025 at 03:45:30PM +, Gote, Nitin R wrote: >> > [...] >> > > Subject: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA >> > > alloc >

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-12 Thread Janusz Krzysztofik
On Wednesday, 11 June 2025 22:54:40 CEST Andi Shyti wrote: > Hi Nitin, > > On Wed, Jun 11, 2025 at 03:45:30PM +, Gote, Nitin R wrote: > > [...] > > > Subject: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA > > > alloc > > > error > > > > > > > Generally, it's preferred to us

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-11 Thread Andi Shyti
Hi Nitin, On Wed, Jun 11, 2025 at 03:45:30PM +, Gote, Nitin R wrote: > [...] > > Subject: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA > > alloc > > error > > > > Generally, it's preferred to use "drm/i915/gt:" file path over > "drm/i915/ring_submission:"  file name in th

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-11 Thread Andi Shyti
Hi Janusz, On Wed, Jun 11, 2025 at 12:42:13PM +0200, Janusz Krzysztofik wrote: > The following error has been reported sporadically by CI when a test > unbinds the i915 driver on a ring submission platform: > > <4> [239.330153] [ cut here ] > <4> [239.330166] i915 :00:

RE: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-11 Thread Gote, Nitin R
Hi Janusz, [...] > Subject: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc > error > Generally, it's preferred to use "drm/i915/gt:" file path over "drm/i915/ring_submission:"  file name in the commit title. Otherwise, the patch looks good to me. Reviewed-by: Nitin Gote

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-11 Thread Krzysztof Karas
Hi Janusz, [...] > If successful then that function, or its execlists or GuC submission > equivalent, is supposed to be called only once per GEM context engine, Could you clarify "execlists or GuC submission equivalent" here - do these functions perform similar reference acquisition, which may be

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-10 Thread Krzysztof Niemiec
Hi Janusz, On 2025-06-06 at 15:58:08 GMT, Janusz Krzysztofik wrote: > The following error has been reported sporadically by CI when a test > unbinds the i915 driver on a ring submission platform: > > <4> [239.330153] [ cut here ] > <4> [239.330166] i915 :00:02.0: [drm]

Re: [PATCH] drm/i915/ring_submission: Fix timeline left held on VMA alloc error

2025-06-10 Thread Sebastian Brzezinka
On Fri Jun 6, 2025 at 1:58 PM UTC, Janusz Krzysztofik wrote: > The following error has been reported sporadically by CI when a test > unbinds the i915 driver on a ring submission platform: > > <4> [239.330153] [ cut here ] > <4> [239.330166] i915 :00:02.0: [drm] > drm_W