Oops in i915 intel_init_clock_gating

2011-06-23 Thread Florian Mickler
On Wed, 22 Jun 2011 15:04:56 -0400 (EDT) Alan Stern wrote: > On Wed, 22 Jun 2011, Keith Packard wrote: > > > On Wed, 15 Jun 2011 13:32:56 -0700, Jesse Barnes > virtuousgeek.org> wrote: > > > > I haven't seen any comments as to whether this patch needs to be merged > > into the kernel. Has anyo

Oops in i915 intel_init_clock_gating

2011-06-23 Thread Alan Stern
On Thu, 23 Jun 2011, Florian Mickler wrote: > On Wed, 22 Jun 2011 15:04:56 -0400 (EDT) > Alan Stern wrote: > > > On Wed, 22 Jun 2011, Keith Packard wrote: > > > > > On Wed, 15 Jun 2011 13:32:56 -0700, Jesse Barnes > > virtuousgeek.org> wrote: > > > > > > I haven't seen any comments as to whet

Re: Oops in i915 intel_init_clock_gating

2011-06-23 Thread Alan Stern
On Thu, 23 Jun 2011, Florian Mickler wrote: > On Wed, 22 Jun 2011 15:04:56 -0400 (EDT) > Alan Stern wrote: > > > On Wed, 22 Jun 2011, Keith Packard wrote: > > > > > On Wed, 15 Jun 2011 13:32:56 -0700, Jesse Barnes > > > wrote: > > > > > > I haven't seen any comments as to whether this patch

Re: Oops in i915 intel_init_clock_gating

2011-06-23 Thread Florian Mickler
On Wed, 22 Jun 2011 15:04:56 -0400 (EDT) Alan Stern wrote: > On Wed, 22 Jun 2011, Keith Packard wrote: > > > On Wed, 15 Jun 2011 13:32:56 -0700, Jesse Barnes > > wrote: > > > > I haven't seen any comments as to whether this patch needs to be merged > > into the kernel. Has anyone tested this?

Oops in i915 intel_init_clock_gating

2011-06-22 Thread Alan Stern
On Wed, 22 Jun 2011, Keith Packard wrote: > On Wed, 15 Jun 2011 13:32:56 -0700, Jesse Barnes virtuousgeek.org> wrote: > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > > b/drivers/gpu/drm/i915/i915_drv.c > > index 0defd42..a1a28fb 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/dr

Re: Oops in i915 intel_init_clock_gating

2011-06-22 Thread Alan Stern
On Wed, 22 Jun 2011, Keith Packard wrote: > On Wed, 15 Jun 2011 13:32:56 -0700, Jesse Barnes > wrote: > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > > b/drivers/gpu/drm/i915/i915_drv.c > > index 0defd42..a1a28fb 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i

Re: Oops in i915 intel_init_clock_gating

2011-06-22 Thread Keith Packard
On Wed, 15 Jun 2011 13:32:56 -0700, Jesse Barnes wrote: > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 0defd42..a1a28fb 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -429,6 +429,9 @@ static int i915_drm_thaw(

Oops in i915 intel_init_clock_gating

2011-06-22 Thread Keith Packard
On Wed, 15 Jun 2011 13:32:56 -0700, Jesse Barnes wrote: > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 0defd42..a1a28fb 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -429,6 +429,9 @@ static int i915_drm_thaw(

Oops in i915 intel_init_clock_gating

2011-06-15 Thread Alan Stern
On Wed, 15 Jun 2011, Jesse Barnes wrote: > On Wed, 15 Jun 2011 16:08:51 -0400 (EDT) > Alan Stern wrote: > > > The problem of dev_priv->display.init_clock_gating not getting set is > > still present in 3.0-rc3. On my system this happens because > > intel_init_display() never gets called in the

Oops in i915 intel_init_clock_gating

2011-06-15 Thread Alan Stern
The problem of dev_priv->display.init_clock_gating not getting set is still present in 3.0-rc3. On my system this happens because intel_init_display() never gets called in the first place. AFAICT, the normal calling sequence during driver initialization is: i915_driver_load() -> i915_l

Re: Oops in i915 intel_init_clock_gating

2011-06-15 Thread Alan Stern
On Wed, 15 Jun 2011, Jesse Barnes wrote: > On Wed, 15 Jun 2011 16:08:51 -0400 (EDT) > Alan Stern wrote: > > > The problem of dev_priv->display.init_clock_gating not getting set is > > still present in 3.0-rc3. On my system this happens because > > intel_init_display() never gets called in the

Re: Oops in i915 intel_init_clock_gating

2011-06-15 Thread Jesse Barnes
On Wed, 15 Jun 2011 16:08:51 -0400 (EDT) Alan Stern wrote: > The problem of dev_priv->display.init_clock_gating not getting set is > still present in 3.0-rc3. On my system this happens because > intel_init_display() never gets called in the first place. > > AFAICT, the normal calling sequence

Oops in i915 intel_init_clock_gating

2011-06-15 Thread Jesse Barnes
On Wed, 15 Jun 2011 16:08:51 -0400 (EDT) Alan Stern wrote: > The problem of dev_priv->display.init_clock_gating not getting set is > still present in 3.0-rc3. On my system this happens because > intel_init_display() never gets called in the first place. > > AFAICT, the normal calling sequence

Re: Oops in i915 intel_init_clock_gating

2011-06-15 Thread Alan Stern
The problem of dev_priv->display.init_clock_gating not getting set is still present in 3.0-rc3. On my system this happens because intel_init_display() never gets called in the first place. AFAICT, the normal calling sequence during driver initialization is: i915_driver_load() -> i915_l