Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-12 Thread Felix Kuehling
On 2018-03-12 03:37 PM, Daniel Vetter wrote: > On Mon, Mar 12, 2018 at 7:17 PM, Felix Kuehling > wrote: >> On 2018-03-07 03:34 PM, Felix Kuehling wrote: Again stop worrying about ioctl overhead, this isn't Windows. If you can show the overhead as being a problem then address it, but I >

Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-12 Thread Daniel Vetter
On Mon, Mar 12, 2018 at 7:17 PM, Felix Kuehling wrote: > On 2018-03-07 03:34 PM, Felix Kuehling wrote: >>> Again stop worrying about ioctl overhead, this isn't Windows. If you >>> can show the overhead as being a problem then address it, but I >>> think it's premature worrying about it at this sta

Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-12 Thread Felix Kuehling
On 2018-03-07 03:34 PM, Felix Kuehling wrote: >> Again stop worrying about ioctl overhead, this isn't Windows. If you >> can show the overhead as being a problem then address it, but I >> think it's premature worrying about it at this stage. > I'd like syscall overhead to be small. But with recent

Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-07 Thread Felix Kuehling
Thanks for the feedback. I'm answering some of your questions inline. On 2018-03-06 06:09 PM, Dave Airlie wrote: > On 7 March 2018 at 08:44, Felix Kuehling wrote: >> Hi all, >> >> Christian raised two potential issues in a recent KFD upstreaming code >> review that are related to the KFD ioctl AP

Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-07 Thread Alex Deucher
On Wed, Mar 7, 2018 at 11:38 AM, Daniel Vetter wrote: > On Wed, Mar 07, 2018 at 09:38:03AM +0100, Christian K??nig wrote: >> Am 07.03.2018 um 00:09 schrieb Dave Airlie: >> > On 7 March 2018 at 08:44, Felix Kuehling wrote: >> > > Hi all, >> > > >> > > Christian raised two potential issues in a rec

Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-07 Thread Daniel Vetter
On Wed, Mar 07, 2018 at 09:38:03AM +0100, Christian K??nig wrote: > Am 07.03.2018 um 00:09 schrieb Dave Airlie: > > On 7 March 2018 at 08:44, Felix Kuehling wrote: > > > Hi all, > > > > > > Christian raised two potential issues in a recent KFD upstreaming code > > > review that are related to the

Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-07 Thread Christian König
Am 07.03.2018 um 00:34 schrieb Jerome Glisse: On Tue, Mar 06, 2018 at 05:44:41PM -0500, Felix Kuehling wrote: Hi all, Christian raised two potential issues in a recent KFD upstreaming code review that are related to the KFD ioctl APIs: 1. behaviour of -ERESTARTSYS 2. transactional nature o

Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-07 Thread Christian König
Am 07.03.2018 um 00:09 schrieb Dave Airlie: On 7 March 2018 at 08:44, Felix Kuehling wrote: Hi all, Christian raised two potential issues in a recent KFD upstreaming code review that are related to the KFD ioctl APIs: 1. behaviour of -ERESTARTSYS 2. transactional nature of KFD ioctl defin

Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-06 Thread Jerome Glisse
On Tue, Mar 06, 2018 at 05:44:41PM -0500, Felix Kuehling wrote: > Hi all, > > Christian raised two potential issues in a recent KFD upstreaming code > review that are related to the KFD ioctl APIs: > > 1. behaviour of -ERESTARTSYS > 2. transactional nature of KFD ioctl definitions, or lack ther

Re: New KFD ioctls: taking the skeletons out of the closet

2018-03-06 Thread Dave Airlie
On 7 March 2018 at 08:44, Felix Kuehling wrote: > Hi all, > > Christian raised two potential issues in a recent KFD upstreaming code > review that are related to the KFD ioctl APIs: > > 1. behaviour of -ERESTARTSYS > 2. transactional nature of KFD ioctl definitions, or lack thereof > > I appreci

New KFD ioctls: taking the skeletons out of the closet

2018-03-06 Thread Felix Kuehling
Hi all, Christian raised two potential issues in a recent KFD upstreaming code review that are related to the KFD ioctl APIs: 1. behaviour of -ERESTARTSYS 2. transactional nature of KFD ioctl definitions, or lack thereof I appreciate constructive feedback, but I also want to encourage an open-