Re: How to gracefully handle pci remove

2018-08-30 Thread Daniel Vetter
On Wed, Aug 29, 2018 at 8:28 PM, Andrey Grodzovsky wrote: > Actually, I've just spotted this drm_dev_unplug, does it make sense to use > it in our pci_driver.remove hook > > instead of explicitly doing drm_dev_unregister and drm_dev_put(dev) ? > > This way at least any following IOCTL will fail wi

Re: How to gracefully handle pci remove

2018-08-29 Thread Deucher, Alexander
devel; Koenig, Christian Subject: Re: How to gracefully handle pci remove Actually, I've just spotted this drm_dev_unplug, does it make sense to use it in our pci_driver.remove hook instead of explicitly doing drm_dev_unregister and drm_dev_put(dev) ? This way at least any following IOCTL

Re: How to gracefully handle pci remove

2018-08-29 Thread Andrey Grodzovsky
Actually, I've just spotted this drm_dev_unplug, does it make sense to use it in our pci_driver.remove hook instead of explicitly doing drm_dev_unregister and drm_dev_put(dev) ? This way at least any following IOCTL will fail with ENODEV. Andrey On 08/29/2018 11:07 AM, Daniel Vetter wrote:

Re: How to gracefully handle pci remove

2018-08-29 Thread Andrey Grodzovsky
Thanks. Andrey On 08/29/2018 11:07 AM, Daniel Vetter wrote: On Wed, Aug 29, 2018 at 4:43 PM, Andrey Grodzovsky wrote: Just another ping... Daniel, Dave - maybe you could give some advise on that ? P.S I tried with Intel card (i915) driver on 4.18.1 kernel to do the same to get some referen

Re: How to gracefully handle pci remove

2018-08-29 Thread Daniel Vetter
On Wed, Aug 29, 2018 at 4:43 PM, Andrey Grodzovsky wrote: > Just another ping... > > Daniel, Dave - maybe you could give some advise on that ? > > P.S I tried with Intel card (i915) driver on 4.18.1 kernel to do the same to > get some reference point, but it just hanged. drm_device hot-unplug is

Re: How to gracefully handle pci remove

2018-08-29 Thread Andrey Grodzovsky
Just another ping... Daniel, Dave - maybe you could give some advise on that ? P.S I tried with Intel card (i915) driver on 4.18.1 kernel to do the same to get some reference point, but it just hanged. Andrey On 08/27/2018 12:04 PM, Andrey Grodzovsky wrote: Hi everybody , I am trying to re

How to gracefully handle pci remove

2018-08-27 Thread Andrey Grodzovsky
Hi everybody , I am trying to resolve various problems I observe when logically removing AMDGPU device from pci - echo 1 > /sys/class/drm/card0/device/remove One of the problems I encountered was hitting WARNs  in amdgpu_gem_force_release. It complaints  about still open client FDs and BOs al