2017-05-09 10:03 GMT+02:00 Benjamin Gaignard :
> 2017-05-06 19:00 GMT+02:00 SF Markus Elfring :
1. I suggest to combine a few functions into fewer ones.
* Do you spot any programming mistakes in these concrete cases?
>>>
>>> Not in the patches I skimmed.
>>
>> Thanks for such feedback.
2017-05-06 19:00 GMT+02:00 SF Markus Elfring :
>>> 1. I suggest to combine a few functions into fewer ones.
>>>* Do you spot any programming mistakes in these concrete cases?
>>
>> Not in the patches I skimmed.
>
> Thanks for such feedback.
>
>
>> However, your history of breaking code tells me
>> 1. I suggest to combine a few functions into fewer ones.
>>* Do you spot any programming mistakes in these concrete cases?
>
> Not in the patches I skimmed.
Thanks for such feedback.
> However, your history of breaking code tells me that there have been mistakes
> missed in the past.
I
On Sat, May 06, 2017 at 03:54:51PM +0200, SF Markus Elfring wrote:
> > Generally speaking, I don't care about checkpatch/cocci changes that aren't
> > tested.
>
> I find this view interesting only to some degree.
We're bordering on becoming unproductive here, but I'll try once more.
>
> 1. I s
> Generally speaking, I don't care about checkpatch/cocci changes that aren't
> tested.
I find this view interesting only to some degree.
1. I suggest to combine a few functions into fewer ones.
* Do you spot any programming mistakes in these concrete cases?
* Can such code reduction resul
On Fri, May 05, 2017 at 05:04:40PM +0200, SF Markus Elfring wrote:
> > It seems like you're back to submitting cocci patches again :)
>
> My contribution activities are varying also for Linux software over time.
> ;-)
>
> The corresponding source code search patterns get different popularity.
> It seems like you're back to submitting cocci patches again :)
My contribution activities are varying also for Linux software over time. ;-)
The corresponding source code search patterns get different popularity.
> I don't want to waste your time by ignoring your patches, so please ensure
On Fri, May 05, 2017 at 03:50:49PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Fri, 5 May 2017 15:45:45 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
Hi Markus,
It seems like you're back to submitting cocci patches again :)
From: Markus Elfring
Date: Fri, 5 May 2017 15:45:45 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Reduce function calls for sequence output at five places
Replace 17 seq_puts() calls by seq_putc()
Fix a typo in a comment line
