Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-07-24 Thread Werner Sembach
Hi Am 24.07.24 um 19:36 schrieb Pavel Machek: Hi! IMO working with the HID LampArray is the way forward. So I would suggest to convert any non-HID RGB "LED display" that we are talking about as a HID LampArray device through `hid_allocate_device()` in the kernel. Basically what you are suggest

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-07-24 Thread Werner Sembach
Hi Am 24.07.24 um 19:36 schrieb Pavel Machek: Hi! IMO working with the HID LampArray is the way forward. So I would suggest to convert any non-HID RGB "LED display" that we are talking about as a HID LampArray device through `hid_allocate_device()` in the kernel. Basically what you are suggest

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-07-24 Thread Pavel Machek
Hi! > > IMO working with the HID LampArray is the way forward. So I would > > suggest to convert any non-HID RGB "LED display" that we are talking > > about as a HID LampArray device through `hid_allocate_device()` in the > > kernel. Basically what you are suggesting Hans. It's just that you don't

Keybaords with arrays of RGB LEDs was Re: Future handling of complex RGB devices on Linux v2

2024-07-23 Thread Pavel Machek
Hi! So... I got two gaming keyboards. One is totally unusable (and it looks LEDs are not controllable from the host), and the second one is .. HyperX Elite RGB. Needs 2 USB connections, very buggy, probably needs repair, and I'd not recomend it to anyone. But that one seems to be usable for RGB ke

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-04-09 Thread Andy Shevchenko
On Mon, Mar 25, 2024 at 07:38:46PM +0100, Miguel Ojeda wrote: > On Mon, Mar 25, 2024 at 3:25 PM Hans de Goede wrote: > > > > +Cc: Bentiss, Jiri > > Cc'ing Andy and Geert as well who recently became the > maintainers/reviewers of auxdisplay, in case they are interested in > these threads (one of t

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-28 Thread Werner Sembach
Hi Benjamin, Am 27.03.24 um 12:03 schrieb Benjamin Tissoires: On Mar 26 2024, Werner Sembach wrote: Hi all, Am 26.03.24 um 16:39 schrieb Benjamin Tissoires: On Mar 26 2024, Werner Sembach wrote: Hi all, Am 25.03.24 um 19:30 schrieb Hans de Goede: [snip] If the kernel already handles the c

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-27 Thread Benjamin Tissoires
On Mar 26 2024, Werner Sembach wrote: > Hi all, > > Am 26.03.24 um 16:39 schrieb Benjamin Tissoires: > > On Mar 26 2024, Werner Sembach wrote: > > > Hi all, > > > > > > Am 25.03.24 um 19:30 schrieb Hans de Goede: > > > > > > [snip] > > > > > > If the kernel already handles the custom protocol in

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-27 Thread Hans de Goede
Hi, On 3/26/24 4:39 PM, Benjamin Tissoires wrote: > On Mar 26 2024, Werner Sembach wrote: >> Hi all, >> >> Am 25.03.24 um 19:30 schrieb Hans de Goede: >> >> [snip] > If the kernel already handles the custom protocol into generic HID, the > work for userspace is not too hard because they ca

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-26 Thread Werner Sembach
Hi all, Am 26.03.24 um 16:39 schrieb Benjamin Tissoires: On Mar 26 2024, Werner Sembach wrote: Hi all, Am 25.03.24 um 19:30 schrieb Hans de Goede: [snip] If the kernel already handles the custom protocol into generic HID, the work for userspace is not too hard because they can deal with a kn

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-26 Thread Benjamin Tissoires
On Mar 26 2024, Werner Sembach wrote: > Hi all, > > Am 25.03.24 um 19:30 schrieb Hans de Goede: > > [snip] > > > > If the kernel already handles the custom protocol into generic HID, the > > > > work for userspace is not too hard because they can deal with a known > > > > protocol and can be cros

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-26 Thread Werner Sembach
Hi all, Am 25.03.24 um 19:30 schrieb Hans de Goede: [snip] If the kernel already handles the custom protocol into generic HID, the work for userspace is not too hard because they can deal with a known protocol and can be cross-platform in their implementation. I'm mentioning that cross-platfor

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Miguel Ojeda
On Mon, Mar 25, 2024 at 3:25 PM Hans de Goede wrote: > > +Cc: Bentiss, Jiri Cc'ing Andy and Geert as well who recently became the maintainers/reviewers of auxdisplay, in case they are interested in these threads (one of the initial solutions discussed in a past thread a while ago was to extend au

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Hans de Goede
Hi Werner, On 3/25/24 5:48 PM, Werner Sembach wrote: > Hi Benjamin, > > Am 25.03.24 um 16:56 schrieb Benjamin Tissoires: >> On Mar 25 2024, Hans de Goede wrote: >>> +Cc: Bentiss, Jiri >>> >>> Hi Werner, >>> >>> On 3/20/24 12:16 PM, Werner Sembach wrote: Hi Hans and the others, Am 2

Re: Future handling of complex RGB devices on Linux v3

2024-03-25 Thread Werner Sembach
Hi Hans, Am 25.03.24 um 15:18 schrieb Hans de Goede: Hi Werner, On 3/19/24 4:18 PM, Werner Sembach wrote: Hi Hans, Am 18.03.24 um 12:11 schrieb Hans de Goede: Hi Werner, Sorry for the late reply. np On 2/22/24 2:14 PM, Werner Sembach wrote: Hi, Thanks everyone for the exhaustive feedbac

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Werner Sembach
Hi Benjamin, Am 25.03.24 um 16:56 schrieb Benjamin Tissoires: On Mar 25 2024, Hans de Goede wrote: +Cc: Bentiss, Jiri Hi Werner, On 3/20/24 12:16 PM, Werner Sembach wrote: Hi Hans and the others, Am 22.02.24 um 14:14 schrieb Werner Sembach: Hi, Thanks everyone for the exhaustive feedback.

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Benjamin Tissoires
On Mar 25 2024, Hans de Goede wrote: > +Cc: Bentiss, Jiri > > Hi Werner, > > On 3/20/24 12:16 PM, Werner Sembach wrote: > > Hi Hans and the others, > > > > Am 22.02.24 um 14:14 schrieb Werner Sembach: > >> Hi, > >> > >> Thanks everyone for the exhaustive feedback. And at least this thread is a

In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-03-25 Thread Hans de Goede
+Cc: Bentiss, Jiri Hi Werner, On 3/20/24 12:16 PM, Werner Sembach wrote: > Hi Hans and the others, > > Am 22.02.24 um 14:14 schrieb Werner Sembach: >> Hi, >> >> Thanks everyone for the exhaustive feedback. And at least this thread is a >> good comprehesive reference for the future ^^. >> >> To

Re: Future handling of complex RGB devices on Linux v3

2024-03-25 Thread Hans de Goede
Hi Werner, On 3/19/24 4:18 PM, Werner Sembach wrote: > Hi Hans, > > Am 18.03.24 um 12:11 schrieb Hans de Goede: >> Hi Werner, >> >> Sorry for the late reply. > np >> >> On 2/22/24 2:14 PM, Werner Sembach wrote: >>> Hi, >>> >>> Thanks everyone for the exhaustive feedback. And at least this thread

Re: Future handling of complex RGB devices on Linux v3

2024-03-20 Thread Werner Sembach
Am 20.03.24 um 12:33 schrieb Werner Sembach: Am 20.03.24 um 12:16 schrieb Werner Sembach: Hi Hans and the others, Am 22.02.24 um 14:14 schrieb Werner Sembach: Hi, Thanks everyone for the exhaustive feedback. And at least this thread is a good comprehesive reference for the future ^^. To

Re: Future handling of complex RGB devices on Linux v3

2024-03-20 Thread Werner Sembach
Am 20.03.24 um 12:16 schrieb Werner Sembach: Hi Hans and the others, Am 22.02.24 um 14:14 schrieb Werner Sembach: Hi, Thanks everyone for the exhaustive feedback. And at least this thread is a good comprehesive reference for the future ^^. To recap the hopefully final UAPI for complex RGB

Re: Future handling of complex RGB devices on Linux v3

2024-03-20 Thread Werner Sembach
Hi Hans and the others, Am 22.02.24 um 14:14 schrieb Werner Sembach: Hi, Thanks everyone for the exhaustive feedback. And at least this thread is a good comprehesive reference for the future ^^. To recap the hopefully final UAPI for complex RGB lighting devices: - By default there is a sing

Re: Future handling of complex RGB devices on Linux v3

2024-03-19 Thread Werner Sembach
Hi Hans, Am 18.03.24 um 12:11 schrieb Hans de Goede: Hi Werner, Sorry for the late reply. np On 2/22/24 2:14 PM, Werner Sembach wrote: Hi, Thanks everyone for the exhaustive feedback. And at least this thread is a good comprehesive reference for the future ^^. To recap the hopefully fina

Re: Future handling of complex RGB devices on Linux v3

2024-03-18 Thread Hans de Goede
Hi Werner, Sorry for the late reply. On 2/22/24 2:14 PM, Werner Sembach wrote: > Hi, > > Thanks everyone for the exhaustive feedback. And at least this thread is a > good comprehesive reference for the future ^^. > > To recap the hopefully final UAPI for complex RGB lighting devices: > > - By

Re: Future handling of complex RGB devices on Linux v2

2024-02-23 Thread Thomas Zimmermann
Hi Am 22.02.24 um 18:38 schrieb Pavel Machek: Hi! so after more feedback from the OpenRGB maintainers I came up with an even more generic proposal: https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 evaluate-set-command ioctl taking: {     enum command                /*

Re: Future handling of complex RGB devices on Linux v2

2024-02-23 Thread Pekka Paalanen
On Thu, 22 Feb 2024 18:38:16 +0100 Pavel Machek wrote: > Hi! > > > > > so after more feedback from the OpenRGB maintainers I came up with an > > > > even > > > > more generic proposal: > > > > https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 > > > > > > > > > > >

Re: Future handling of complex RGB devices on Linux v2

2024-02-23 Thread Werner Sembach
Hi, Am 21.02.24 um 23:17 schrieb Pavel Machek: Hi! so after more feedback from the OpenRGB maintainers I came up with an even more generic proposal: https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 evaluate-set-command ioctl taking: {     enum command                /

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Pavel Machek
Hi! > For all these reasons the display analogy really is a bit fit for these > keyboards > we tried to come up with a universal coordinate system for these at the > beginning > of the thread and we failed ... I quite liked the coordinate system proposal. I can propose this: Vendor maps the ke

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Pavel Machek
Hi! > > To be honest, I think the kernel shouldn't include too much high-level > > complexity. If there is a desire to implement a generic display device on > > top of the RGB device, this should be a configurable service running in > > user space. The kernel should provide an interface to expo

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Pavel Machek
Hi! > > > so after more feedback from the OpenRGB maintainers I came up with an even > > > more generic proposal: > > > https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 > > > > > >evaluate-set-command ioctl taking: > > > >{ > > > >    enum command                /* one o

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Pavel Machek
Hi! > > Yeah, so ... this is not a interface. This is a backdoor to pass > > arbitrary data. That's not going to fly. > > Pavel, Note the data will be interpreted by a kernel driver and > not passed directly to the hw. Yes, still not flying :-). > With that said I tend to agree that this seems

Re: Future handling of complex RGB devices on Linux v3

2024-02-22 Thread Werner Sembach
Hi, Thanks everyone for the exhaustive feedback. And at least this thread is a good comprehesive reference for the future ^^. To recap the hopefully final UAPI for complex RGB lighting devices: - By default there is a singular /sys/class/leds/* entry that treats the device as if it was a sin

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Gregor Riepl
This certainly is the most KISS approach. This proposal in essence is just an arbitrary command multiplexer / demultiplexer and ioctls already are exactly that. With the added advantage of being able to directly use pass the vendor-cmd-specific struct to the ioctl instead of having to first embed

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Hans de Goede
Hi, On 2/22/24 12:38, Gregor Riepl wrote: >> This certainly is the most KISS approach. This proposal >> in essence is just an arbitrary command multiplexer / >> demultiplexer and ioctls already are exactly that. >> >> With the added advantage of being able to directly use >> pass the vendor-cmd-sp

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Hans de Goede
Hi, On 2/21/24 23:17, Pavel Machek wrote: > Hi! > >> so after more feedback from the OpenRGB maintainers I came up with an even >> more generic proposal: >> https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 > >>> evaluate-set-command ioctl taking: >>> { >>>     enum comman

Re: Future handling of complex RGB devices on Linux v2

2024-02-22 Thread Pekka Paalanen
On Wed, 21 Feb 2024 23:17:52 +0100 Pavel Machek wrote: > Hi! > > > so after more feedback from the OpenRGB maintainers I came up with an even > > more generic proposal: > > https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 > > > >evaluate-set-command ioctl taking: > > >

Re: Future handling of complex RGB devices on Linux v2

2024-02-21 Thread Pavel Machek
Hi! > so after more feedback from the OpenRGB maintainers I came up with an even > more generic proposal: > https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 > >evaluate-set-command ioctl taking: > >{ > >    enum command                /* one of supported_commands */ > >   

Future handling of complex RGB devices on Linux v2

2024-02-21 Thread Werner Sembach
Hi, so after more feedback from the OpenRGB maintainers I came up with an even more generic proposal: https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 Copy pasting the relevant part: >Another, yet more generic, approach: > >``` >get-device-info ioctl returning: >{ >  

Re: Future handling of complex RGB devices on Linux

2024-01-31 Thread Roderick Colenbrander
e up witrh this rough updated draft for the new uapi: > > Future handling of complex RGB devices on Linux: > > Optional: Provide a basic leds-subsystem driver: > - The whole device is treated as a singular RGB led in the current leds > uapi > - Backwards compatib

Future handling of complex RGB devices on Linux

2024-01-31 Thread Werner Sembach
Hi, so I combined Hans last draft, with the discussion since then and the comments from the OpenRGB maintainers from here https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916 and my own experience and came up witrh this rough updated draft for the new uapi: Future handling of complex