[Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Sharma, Shashank
What I understood from the reviews comments from the experts, is having a central color management at DRM kernel layer is not a good idea, and we should create individual DRM properties for the color correction methods, and let the control be there in the user space level, where an atomic modes

[Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 10:52:38AM +0530, Sharma, Shashank wrote: [...] > Please note that the color correction methods changes per platform and > what's valid for one Intel platform may not be valid for other. So the > atomic modeset should have a clear idea of what is supported on which > platfor

[Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Sharma, Shashank
; Korjani, Vikas Subject: Re: [Intel-gfx] Design review request: DRM color manager On Thu, May 15, 2014 at 10:52:38AM +0530, Sharma, Shashank wrote: [...] > Please note that the color correction methods changes per platform and > what's valid for one Intel platform may not be valid for ot

[Intel-gfx] Design review request: DRM color manager

2014-05-14 Thread Thierry Reding
On Tue, May 13, 2014 at 09:18:45AM +0530, Sharma, Shashank wrote: > Daniel, > Please find my comments inline. > > Regards > Shashank > On 5/12/2014 8:58 PM, Daniel Vetter wrote: > >On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote: > >>Thanks for your time and the comments David. >

[Intel-gfx] Design review request: DRM color manager

2014-05-13 Thread Sharma, Shashank
Daniel, Please find my comments inline. Regards Shashank On 5/12/2014 8:58 PM, Daniel Vetter wrote: > On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote: >> Thanks for your time and the comments David. >> please find mine inline. >> >> Regards >> Shashank >> On 5/12/2014 5:20 PM, Dav

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread David Herrmann
Hi On Mon, May 12, 2014 at 5:28 PM, Daniel Vetter wrote: > Those are all just reasons for atomic modeset and maybe an atomic modeget > ioctl which transfers the entire blob of things. Maybe we should start > with the atomic modeget to get things rolling. Otoh you can always do that > in userspace

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Sharma, Shashank
Thanks for your time and the comments David. please find mine inline. Regards Shashank On 5/12/2014 5:20 PM, David Herrmann wrote: > Hi > > On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank > wrote: >> Benefits of using color manager: >> >> 1. Unique framework fo

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Daniel Vetter
On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote: > Thanks for your time and the comments David. > please find mine inline. > > Regards > Shashank > On 5/12/2014 5:20 PM, David Herrmann wrote: > >Hi > > > >On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank > > wrote: > >>Benefits o

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Sharma, Shashank
oefficients or any other form of data. >> >> Benefits of this common interface: >> -- >> - Single interface for all color properties. No need to create multiple >>properties. >> - HW agonist. Its in hands of driver to register

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread David Herrmann
Hi On Mon, May 12, 2014 at 12:26 PM, Sharma, Shashank wrote: > Benefits of using color manager: > > 1. Unique framework for all the color correction properties, across all >DRM drivers, across various platforms. > 2. Only one set/get call for all kind of prope

[Intel-gfx] Design review request: DRM color manager

2014-05-12 Thread Daniel Vetter
- Can be clubbed with modeset implementations. > > > > > Regards > Shashank > > On 5/7/2014 7:41 PM, Sharma, Shashank wrote: >> >> FYI >> >> >> -Original Message- >> From: Sharma, Shashank >> Sent: Tuesday, April 22, 2014 8:32

[Intel-gfx] Design review request: DRM color manager

2014-04-22 Thread Daniel Vetter
rjani, Vikas; Shankar, Uma; > Cn, Ramakrishnan > Subject: Re: Design review request: DRM color manager > > Hi > > On Tue, Apr 22, 2014 at 12:21 PM, Sharma, Shashank intel.com> wrote: > > 1) Why do you register only a single property? Why not register a separate > >

Design review request: DRM color manager

2014-04-22 Thread David Herrmann
Hi On Tue, Apr 22, 2014 at 12:21 PM, Sharma, Shashank wrote: > 1) Why do you register only a single property? Why not register a separate > property for each color-correction that is available? This way you can drop > the property-id and use the high-level DRM-prop IDs/names. >>> That?s the who

Design review request: DRM color manager

2014-04-22 Thread Sharma, Shashank
Reding; Alex Deucher; Sean Paul; robdclark at gmail.com; Mukherjee, Indranil; Jindal, Sonika; Korjani, Vikas; Shankar, Uma; Cn, Ramakrishnan Subject: Re: Design review request: DRM color manager Hi On Tue, Apr 22, 2014 at 12:21 PM, Sharma, Shashank wrote: > 1) Why do you register only a sin

Design review request: DRM color manager

2014-04-22 Thread David Herrmann
Hi On Tue, Apr 22, 2014 at 6:11 AM, Sharma, Shashank wrote: > Gentle reminder Usual approach is to send any proposals as inline plain-text. It's really hard to comment on attachments, especially if it's an MS-office format. Anyhow, some comments on the proposal: 1) Why do you register only a si

Design review request: DRM color manager

2014-04-22 Thread Sharma, Shashank
lists.freedesktop.org; Ville Syrj?l?; Thierry Reding; Alex Deucher; Sean Paul; robdclark at gmail.com; Mukherjee, Indranil; Jindal, Sonika; Korjani, Vikas; Shankar, Uma; Cn, Ramakrishnan Subject: Re: Design review request: DRM color manager Hi On Tue, Apr 22, 2014 at 6:11 AM, Sharma, Shashank wrote

Design review request: DRM color manager

2014-04-22 Thread Sharma, Shashank
; Korjani, Vikas; Jindal, Sonika; Mukherjee, Indranil; Cn, Ramakrishnan Subject: Design review request: DRM color manager Hi All, Based on all the previous feedbacks, we have done the design changes in previous color manager implementation. This new design addresses following previous comments

Design review request: DRM color manager

2014-04-18 Thread Sharma, Shashank
Hi All, Based on all the previous feedbacks, we have done the design changes in previous color manager implementation. This new design addresses following previous comments / suggestions / requirements: 1. HW agnostic design, so each driver can register its own capabilities, and own color cor