On 8/31/24 8:03 AM, Sui Jingfeng wrote:
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender
and know the content is safe.
Hi, Xiaolei
Thanks for your nice catch! I have more to say.
On 2024/8/16 09:55, Wang,
Hi, Xiaolei
Thanks for your nice catch! I have more to say.
On 2024/8/16 09:55, Wang, Xiaolei wrote:
Ping ...
32 address -> 32-bit address,
Perhaps, we could improve the commit title a little bit
by writing a more accurate sentence if possible, say:
drm/etnaviv: Properly request pages from
On 2024/8/31 03:40, Sui Jingfeng wrote:
Hi, Xiaolei
On 2024/8/16 09:55, Wang, Xiaolei wrote:
Ping ...
I think, the more proper fix that Lucas hint
is to modify the 'priv->shm_gfp_mask' variable
in the|etnaviv_bind() function|. Say:
|Use "priv->shm_gfp_mask = GFP_USER | __GFP_RETRY_MAYFAIL |
Hi, Xiaolei
On 2024/8/16 09:55, Wang, Xiaolei wrote:
Ping ...
I think, the more proper fix that Lucas hint
is to modify the 'priv->shm_gfp_mask' variable
in the|etnaviv_bind() function|. Say:
|Use "priv->shm_gfp_mask = GFP_USER | __GFP_RETRY_MAYFAIL | __GFP_NOWARN;"|
instead of
|"priv->shm_
@lists.freedesktop.org ;
linux-ker...@vger.kernel.org
Subject: [PATCH v2] drm/etnaviv: Clear the __GFP_HIGHMEM bit in GFP_HIGHUSER
with 32 address
GFP_HIGHUSER is a combination of GFP_USER | __GFP_HIGHMEM.
Only the highmem part is incompatible with DMA32. Reserve
GFP_USER bit here, as the driver
GFP_HIGHUSER is a combination of GFP_USER | __GFP_HIGHMEM.
Only the highmem part is incompatible with DMA32. Reserve
GFP_USER bit here, as the driver allocated buffers might
be mapped to userspace.
Fixes: b72af445cd38 ("drm/etnaviv: request pages from DMA32 zone when needed")
Signed-off-by: Xiaole
