Re: [v2,7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers

2024-02-06 Thread Thomas Zimmermann
Hi Am 02.02.24 um 19:00 schrieb Sui Jingfeng: Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote: +static inline void __screen_info_set_lfb_base(struct screen_info *si, u64 lfb_base) +{ +    si->lfb_base = lfb_base & GENMASK_ULL(31, 0); +    si->ext_lfb_base = (lfb_base & GENMASK_ULL(63, 32)) >>

Re: [v2,7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers

2024-02-05 Thread Thomas Zimmermann
Hi Am 02.02.24 um 18:54 schrieb Sui Jingfeng: Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote: +static inline void __screen_info_set_lfb_base(struct screen_info *si, u64 lfb_base) +{ +    si->lfb_base = lfb_base & GENMASK_ULL(31, 0); +    si->ext_lfb_base = (lfb_base & GENMASK_ULL(63, 32)) >>

Re: [v2,7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers

2024-02-02 Thread Sui Jingfeng
Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote: +static inline void __screen_info_set_lfb_base(struct screen_info *si, u64 lfb_base) +{ + si->lfb_base = lfb_base & GENMASK_ULL(31, 0); + si->ext_lfb_base = (lfb_base & GENMASK_ULL(63, 32)) >> 32; I want to ask a trivial question:

Re: [v2,7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers

2024-02-02 Thread Sui Jingfeng
Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote: +static inline void __screen_info_set_lfb_base(struct screen_info *si, u64 lfb_base) +{ + si->lfb_base = lfb_base & GENMASK_ULL(31, 0); + si->ext_lfb_base = (lfb_base & GENMASK_ULL(63, 32)) >> 32; + + if (si->ext_lfb_base) +