Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-17 Thread harigovi
On 2020-02-12 10:40, Rob Clark wrote: On Tue, Feb 11, 2020 at 8:05 PM Jeffrey Hugo wrote: On Tue, Feb 11, 2020 at 5:28 PM Rob Clark wrote: > > On Tue, Feb 11, 2020 at 7:59 AM Jeffrey Hugo wrote: > > > > On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > > > > > On Mon, Feb 10, 2020 at 9:5

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-12 Thread Jeffrey Hugo
On Tue, Feb 11, 2020 at 5:28 PM Rob Clark wrote: > > On Tue, Feb 11, 2020 at 7:59 AM Jeffrey Hugo wrote: > > > > On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > > > > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > > > > > > On 2020-02-07 19:40, Jeffrey Hugo wrote: > > > > > On Fri, Feb 7,

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-12 Thread Jeffrey Hugo
On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > > On 2020-02-07 19:40, Jeffrey Hugo wrote: > > > On Fri, Feb 7, 2020 at 5:38 AM wrote: > > >> > > >> On 2020-02-06 20:29, Jeffrey Hugo wrote: > > >> > On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-11 Thread Rob Clark
On Tue, Feb 11, 2020 at 8:05 PM Jeffrey Hugo wrote: > > On Tue, Feb 11, 2020 at 5:28 PM Rob Clark wrote: > > > > On Tue, Feb 11, 2020 at 7:59 AM Jeffrey Hugo > > wrote: > > > > > > On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > > > > > > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > >

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-11 Thread Rob Clark
On Tue, Feb 11, 2020 at 7:59 AM Jeffrey Hugo wrote: > > On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > > > > On 2020-02-07 19:40, Jeffrey Hugo wrote: > > > > On Fri, Feb 7, 2020 at 5:38 AM wrote: > > > >> > > > >> On 2020-02-06 20:29, Jeffr

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-11 Thread Rob Clark
On Mon, Feb 10, 2020 at 9:58 PM wrote: > > On 2020-02-07 19:40, Jeffrey Hugo wrote: > > On Fri, Feb 7, 2020 at 5:38 AM wrote: > >> > >> On 2020-02-06 20:29, Jeffrey Hugo wrote: > >> > On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P > >> > wrote: > >> >> > >> >> For a given byte clock, if VCO recal

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-10 Thread harigovi
On 2020-02-07 19:40, Jeffrey Hugo wrote: On Fri, Feb 7, 2020 at 5:38 AM wrote: On 2020-02-06 20:29, Jeffrey Hugo wrote: > On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P > wrote: >> >> For a given byte clock, if VCO recalc value is exactly same as >> vco set rate value, vco_set_rate does not ge

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-10 Thread harigovi
On 2020-02-06 20:29, Jeffrey Hugo wrote: On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P wrote: For a given byte clock, if VCO recalc value is exactly same as vco set rate value, vco_set_rate does not get called assuming VCO is already set to required value. But Due to GDSC toggle, VCO values ar

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-10 Thread Jeffrey Hugo
On Fri, Feb 7, 2020 at 5:38 AM wrote: > > On 2020-02-06 20:29, Jeffrey Hugo wrote: > > On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P > > wrote: > >> > >> For a given byte clock, if VCO recalc value is exactly same as > >> vco set rate value, vco_set_rate does not get called assuming > >> VCO is a

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-07 Thread Jeffrey Hugo
On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P wrote: > > For a given byte clock, if VCO recalc value is exactly same as > vco set rate value, vco_set_rate does not get called assuming > VCO is already set to required value. But Due to GDSC toggle, > VCO values are erased in the HW. To make sure VC

[v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-07 Thread Harigovindan P
For a given byte clock, if VCO recalc value is exactly same as vco set rate value, vco_set_rate does not get called assuming VCO is already set to required value. But Due to GDSC toggle, VCO values are erased in the HW. To make sure VCO is programmed correctly, we forcefully call set_rate from vco_