I developers; Deucher, Alexander; Liu, Monk
> Subject: Re: [patch 1/4] drm/amdgpu: unwind properly in
> amdgpu_cs_parser_init()
>
> On Wed, Sep 23, 2015 at 01:13:21PM -0400, Alex Deucher wrote:
> > Applied. thanks!
>
> Ugh. I'm sorry, I have a signedness bug in this patch.
On Wed, Sep 23, 2015 at 01:13:21PM -0400, Alex Deucher wrote:
> Applied. thanks!
Ugh. I'm sorry, I have a signedness bug in this patch. That was really
sloppy of me. Should a send a v2 or a fixup?
regards,
dan carpenter
On 23.09.2015 12:59, Dan Carpenter wrote:
> The amdgpu_cs_parser_init() function doesn't clean up after itself but
> instead the caller uses a free everything function amdgpu_cs_parser_fini()
> on failure. This style of error handling is often buggy. In this
> example, we call "drm_free_large(par
The amdgpu_cs_parser_init() function doesn't clean up after itself but
instead the caller uses a free everything function amdgpu_cs_parser_fini()
on failure. This style of error handling is often buggy. In this
example, we call "drm_free_large(parser->chunks[i].kdata);" when it is
an unintialized
On Wed, Sep 23, 2015 at 10:16 AM, Christian König
wrote:
> On 23.09.2015 12:59, Dan Carpenter wrote:
>>
>> The amdgpu_cs_parser_init() function doesn't clean up after itself but
>> instead the caller uses a free everything function amdgpu_cs_parser_fini()
>> on failure. This style of error handl
