Re: [patch] i915: take struct_mutex in i915_dma_cleanup()

2010-07-25 Thread Chris Wilson
On Wed, 23 Jun 2010 08:47:18 -0700, Jesse Barnes wrote: > Reminds me, Gordon can you add module unload testing to your set of > basic daily tests? To unload you need to unbind the fbcon interface > first, my script is like this: > > echo 0 > /sys/class/vtconsole/vtcon1/bind > rmmod i915 > rmmod

[patch] i915: take struct_mutex in i915_dma_cleanup()

2010-07-25 Thread Chris Wilson
On Wed, 23 Jun 2010 08:47:18 -0700, Jesse Barnes wrote: > Reminds me, Gordon can you add module unload testing to your set of > basic daily tests? To unload you need to unbind the fbcon interface > first, my script is like this: > > echo 0 > /sys/class/vtconsole/vtcon1/bind > rmmod i915 > rmmod

Re: [patch] i915: take struct_mutex in i915_dma_cleanup()

2010-07-01 Thread Eric Anholt
On Wed, 23 Jun 2010 13:19:55 +0200, Dan Carpenter wrote: > intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as > opposed to drm_gem_object_unreference_unlocked()) so it needs to be > called with "struct_mutex" held. If we don't hold the lock, it triggers > a BUG_ON(!mutex_is_locked

[patch] i915: take struct_mutex in i915_dma_cleanup()

2010-07-01 Thread Eric Anholt
On Wed, 23 Jun 2010 13:19:55 +0200, Dan Carpenter wrote: > intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as > opposed to drm_gem_object_unreference_unlocked()) so it needs to be > called with "struct_mutex" held. If we don't hold the lock, it triggers > a BUG_ON(!mutex_is_locked

Re: [patch] i915: take struct_mutex in i915_dma_cleanup()

2010-06-24 Thread Jesse Barnes
On Wed, 23 Jun 2010 13:19:55 +0200 Dan Carpenter wrote: > intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as > opposed to drm_gem_object_unreference_unlocked()) so it needs to be > called with "struct_mutex" held. If we don't hold the lock, it triggers > a BUG_ON(!mutex_is_locked

[patch] i915: take struct_mutex in i915_dma_cleanup()

2010-06-23 Thread Dan Carpenter
intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as opposed to drm_gem_object_unreference_unlocked()) so it needs to be called with "struct_mutex" held. If we don't hold the lock, it triggers a BUG_ON(!mutex_is_locked(&dev->struct_mutex)); I also audited the other places that call

[patch] i915: take struct_mutex in i915_dma_cleanup()

2010-06-23 Thread Jesse Barnes
On Wed, 23 Jun 2010 13:19:55 +0200 Dan Carpenter wrote: > intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as > opposed to drm_gem_object_unreference_unlocked()) so it needs to be > called with "struct_mutex" held. If we don't hold the lock, it triggers > a BUG_ON(!mutex_is_locked

[patch] i915: take struct_mutex in i915_dma_cleanup()

2010-06-23 Thread Dan Carpenter
intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as opposed to drm_gem_object_unreference_unlocked()) so it needs to be called with "struct_mutex" held. If we don't hold the lock, it triggers a BUG_ON(!mutex_is_locked(&dev->struct_mutex)); I also audited the other places that call