[patch] drm: checking the wrong variable in savage_do_init_bci()

2012-05-17 Thread walter harms
Am 17.05.2012 09:09, schrieb Dan Carpenter: > drm_core_ioremap() initializes ->handle. We already know > "dev->agp_buffer_map" is a valid pointer. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/savage/savage_bci.c > b/drivers/gpu/drm/savage/savage_bci.c > index cb1ee4e..6e

[patch] drm: checking the wrong variable in savage_do_init_bci()

2012-05-17 Thread Dan Carpenter
drm_core_ioremap() initializes ->handle. We already know "dev->agp_buffer_map" is a valid pointer. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c index cb1ee4e..6eb507a 100644 --- a/drivers/gpu/drm/savage/savage_bci.c +++ b/d

Re: [patch] drm: checking the wrong variable in savage_do_init_bci()

2012-05-17 Thread Ian Romanick
On 05/17/2012 12:09 AM, Dan Carpenter wrote: drm_core_ioremap() initializes ->handle. We already know "dev->agp_buffer_map" is a valid pointer. Signed-off-by: Dan Carpenter I'm surprised that has never been hit. Reviewed-by: Ian Romanick diff --git a/drivers/gpu/drm/savage/savage_bci.c

[patch] drm: checking the wrong variable in savage_do_init_bci()

2012-05-17 Thread Ian Romanick
On 05/17/2012 12:09 AM, Dan Carpenter wrote: > drm_core_ioremap() initializes ->handle. We already know > "dev->agp_buffer_map" is a valid pointer. > > Signed-off-by: Dan Carpenter I'm surprised that has never been hit. Reviewed-by: Ian Romanick > > diff --git a/drivers/gpu/drm/savage/savage_b

Re: [patch] drm: checking the wrong variable in savage_do_init_bci()

2012-05-17 Thread walter harms
Am 17.05.2012 09:09, schrieb Dan Carpenter: > drm_core_ioremap() initializes ->handle. We already know > "dev->agp_buffer_map" is a valid pointer. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/savage/savage_bci.c > b/drivers/gpu/drm/savage/savage_bci.c > index cb1ee4e..6e

[patch] drm: checking the wrong variable in savage_do_init_bci()

2012-05-17 Thread Dan Carpenter
drm_core_ioremap() initializes ->handle. We already know "dev->agp_buffer_map" is a valid pointer. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c index cb1ee4e..6eb507a 100644 --- a/drivers/gpu/drm/savage/savage_bci.c +++ b/d