Re: [patch] drm/radeon: signedness bug in kv_dpm.c

2013-09-04 Thread Alex Deucher
On Wed, Sep 4, 2013 at 5:31 AM, Dan Carpenter wrote: > The problem here is that "unsigned i" is always greater than or equal to > zero. These loops mostly have a second check for "(i == 0)" so only the > last two are actually buggy. The rest is just cleanup. > > Bug 1: kv_force_dpm_highest() do

[patch] drm/radeon: signedness bug in kv_dpm.c

2013-09-04 Thread Dan Carpenter
The problem here is that "unsigned i" is always greater than or equal to zero. These loops mostly have a second check for "(i == 0)" so only the last two are actually buggy. The rest is just cleanup. Bug 1: kv_force_dpm_highest() doesn't have an "(i == 0)" check so it's a potential forever loop