[patch] drm/radeon: check for allocation failure in radeon_ring_backup()

2012-07-20 Thread Dan Carpenter
On Fri, Jul 20, 2012 at 03:45:28PM +0200, Christian K?nig wrote: > On 20.07.2012 13:17, Dan Carpenter wrote: > >Static checkers complain if this we don't check for allocation failure. > >Also we can use the new kmalloc_array() function here as a cleanup. > > > >Signed-off-by: Dan Carpenter > What'

[patch] drm/radeon: check for allocation failure in radeon_ring_backup()

2012-07-20 Thread Christian König
On 20.07.2012 13:17, Dan Carpenter wrote: > Static checkers complain if this we don't check for allocation failure. > Also we can use the new kmalloc_array() function here as a cleanup. > > Signed-off-by: Dan Carpenter What's the benefit of using kmalloc_array instead of just kmalloc? Anyway it's

[patch] drm/radeon: check for allocation failure in radeon_ring_backup()

2012-07-20 Thread Dan Carpenter
Static checkers complain if this we don't check for allocation failure. Also we can use the new kmalloc_array() function here as a cleanup. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c index 75cbe46..5a0ef24 100644 --- a/d

Re: [patch] drm/radeon: check for allocation failure in radeon_ring_backup()

2012-07-20 Thread Dan Carpenter
On Fri, Jul 20, 2012 at 03:45:28PM +0200, Christian König wrote: > On 20.07.2012 13:17, Dan Carpenter wrote: > >Static checkers complain if this we don't check for allocation failure. > >Also we can use the new kmalloc_array() function here as a cleanup. > > > >Signed-off-by: Dan Carpenter > What'

[patch] drm/radeon: check for allocation failure in radeon_ring_backup()

2012-07-20 Thread Dan Carpenter
Static checkers complain if this we don't check for allocation failure. Also we can use the new kmalloc_array() function here as a cleanup. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c index 75cbe46..5a0ef24 100644 --- a/d

Re: [patch] drm/radeon: check for allocation failure in radeon_ring_backup()

2012-07-20 Thread Christian König
On 20.07.2012 13:17, Dan Carpenter wrote: Static checkers complain if this we don't check for allocation failure. Also we can use the new kmalloc_array() function here as a cleanup. Signed-off-by: Dan Carpenter What's the benefit of using kmalloc_array instead of just kmalloc? Anyway it's: R