[patch] drm/i915: use _safe version of list_for_each

2013-08-19 Thread Dan Carpenter
We sometimes call i915_vma_unbind() inside the loop and that can free the vma. Signed-off-by: Dan Carpenter --- Static checker stuff. Untested. diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index 9b3b5f8..5249735 100644 --- a/drivers/gpu/d

[patch] drm/i915: use _safe version of list_for_each

2013-08-19 Thread Chris Wilson
On Mon, Aug 19, 2013 at 09:53:23AM +0300, Dan Carpenter wrote: > We sometimes call i915_vma_unbind() inside the loop and that can free > the vma. Oh. That is bad. The vma needs to be pinned here to prevent it being freed as otherwise we lose track of it during the execbuffer. Ben? -Chris -- Chri

Re: [patch] drm/i915: use _safe version of list_for_each

2013-08-19 Thread Chris Wilson
On Mon, Aug 19, 2013 at 09:53:23AM +0300, Dan Carpenter wrote: > We sometimes call i915_vma_unbind() inside the loop and that can free > the vma. Oh. That is bad. The vma needs to be pinned here to prevent it being freed as otherwise we lose track of it during the execbuffer. Ben? -Chris -- Chri

[patch] drm/i915: use _safe version of list_for_each

2013-08-19 Thread Dan Carpenter
We sometimes call i915_vma_unbind() inside the loop and that can free the vma. Signed-off-by: Dan Carpenter --- Static checker stuff. Untested. diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index 9b3b5f8..5249735 100644 --- a/drivers/gpu/d