Re: [patch] drm/atomic: fix an error code in mode_fixup()

2017-02-08 Thread Daniel Vetter
On Wed, Feb 08, 2017 at 02:46:01AM +0300, Dan Carpenter wrote: > Having "ret" be a bool type works for everything except > ret = funcs->atomic_check(). The other functions all return zero on > error but ->atomic_check() returns negative error codes. We want to > propagate the error code but inste

[patch] drm/atomic: fix an error code in mode_fixup()

2017-02-07 Thread Dan Carpenter
Having "ret" be a bool type works for everything except ret = funcs->atomic_check(). The other functions all return zero on error but ->atomic_check() returns negative error codes. We want to propagate the error code but instead we return 1. I found this bug with static analysis and I don't know