Re:Re: [PATCH] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond_vms()

2020-04-19 Thread 赵军奎
David Airlie 主题:Re: [PATCH] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond_vms()>> There is no need to if check again, > >Thanks for this information. > >* Should the function name be mentioned in this change description? > >* Would you like to adj

Re: [PATCH] drm/amdgpu: Remove an unnecessary condition check in reserve_bo_and_cond_vms()

2020-04-19 Thread Markus Elfring
> There is no need to if check again, Thanks for this information. * Should the function name be mentioned in this change description? * Would you like to adjust the patch subject? > maybe we could merge into the above else branch. I suggest to reconsider this wording. … > +++ b/drivers/gpu

[patch] drm/amdgpu: remove an unnecessary condition

2015-06-11 Thread Christian König
On 11.06.2015 10:19, Dan Carpenter wrote: > We already checked "if (r)" so there is no need to check again. > > Signed-off-by: Dan Carpenter Hi Dan, thanks for taking a look into this. This patch and the other two you send today are Reviewed-by: Christian König That code was branched of from

[patch] drm/amdgpu: remove an unnecessary condition

2015-06-11 Thread Dan Carpenter
We already checked "if (r)" so there is no need to check again. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index 5533434..b7d0425 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +++ b/drivers/gpu/drm/amd/amdgp