Re: [bug report] drm: Use atomic state for FB in legacy ioctls

2017-01-23 Thread Daniel Vetter
On Fri, Jan 13, 2017 at 03:12:07PM +, Daniel Stone wrote: > Hi Dan, > > On 13 January 2017 at 12:56, Dan Carpenter wrote: > > drivers/gpu/drm/drm_crtc.c:392 drm_mode_getcrtc() > > error: we previously assumed 'crtc->primary->state' could be null > > (see line 384) > > > > drivers/gp

Re: [bug report] drm: Use atomic state for FB in legacy ioctls

2017-01-13 Thread Daniel Stone
Hi Dan, On 13 January 2017 at 12:56, Dan Carpenter wrote: > drivers/gpu/drm/drm_crtc.c:392 drm_mode_getcrtc() > error: we previously assumed 'crtc->primary->state' could be null > (see line 384) > > drivers/gpu/drm/drm_crtc.c >383 >384 if (crtc->primary->state && crtc->

[bug report] drm: Use atomic state for FB in legacy ioctls

2017-01-13 Thread Dan Carpenter
Hello Daniel Stone, This is a semi-automatic email about new static checker warnings. The patch de7b6be7f300: "drm: Use atomic state for FB in legacy ioctls" from Dec 13, 2016, leads to the following Smatch complaint: drivers/gpu/drm/drm_crtc.c:392 drm_mode_getcrtc() error: we previous