[alsa-devel] [PATCH v3 2/5] ASoC: tda998x: add a codec driver for the TDA998x

2014-02-04 Thread Mark Brown
On Tue, Feb 04, 2014 at 02:36:50PM +0100, Lars-Peter Clausen wrote: > On 02/04/2014 02:30 PM, Mark Brown wrote: > >>+static const struct snd_soc_dapm_route tda_routes[] = { > >>+ { "hdmi-out", NULL, "HDMI I2S Playback" }, > >>+ { "hdmi-out", NULL, "HDMI SPDIF Playback" }, > >>+}; > >S/PDIF.

[alsa-devel] [PATCH v3 2/5] ASoC: tda998x: add a codec driver for the TDA998x

2014-02-04 Thread Lars-Peter Clausen
On 02/04/2014 02:30 PM, Mark Brown wrote: [...] > > What does this actually do? No information is being passed in to the > core function here, not even any information on if it's starting or > stopping. Looking at the rest of the code I can't help thinking it > might be clearer to inline this pos