Re: [WIP RFC v2 33/35] WIP: rust: drm/kms: Add VblankSupport

2025-01-14 Thread Simona Vetter
On Tue, Jan 14, 2025 at 04:04:41PM +0100, Miguel Ojeda wrote: > On Tue, Jan 14, 2025 at 3:24 PM Simona Vetter wrote: > > > > Feels like trying to replicate docs in rust might be dangerous, because if > > we have to keep really detailed and nuanced docs around in two places we > > will fail. > > >

Re: [WIP RFC v2 33/35] WIP: rust: drm/kms: Add VblankSupport

2025-01-14 Thread Miguel Ojeda
On Tue, Jan 14, 2025 at 3:24 PM Simona Vetter wrote: > > Feels like trying to replicate docs in rust might be dangerous, because if > we have to keep really detailed and nuanced docs around in two places we > will fail. > > Imo would be better to just explain how this maps to the C side and link >

Re: [WIP RFC v2 33/35] WIP: rust: drm/kms: Add VblankSupport

2025-01-14 Thread Simona Vetter
On Mon, Jan 13, 2025 at 07:43:44PM -0500, Lyude Paul wrote: > On Thu, 2024-12-05 at 12:29 -0300, Daniel Almeida wrote: > > Hi Lyude, > > > > > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > > > > > > > > @@ -84,6 +86,13 @@ unsafe fn setup_fbdev(drm: &Device, > > > mode_config_info: &ModeConfi

Re: [WIP RFC v2 33/35] WIP: rust: drm/kms: Add VblankSupport

2025-01-13 Thread Lyude Paul
On Thu, 2024-12-05 at 12:29 -0300, Daniel Almeida wrote: > Hi Lyude, > > > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > > > > > @@ -84,6 +86,13 @@ unsafe fn setup_fbdev(drm: &Device, > > mode_config_info: &ModeConfigI > > /// state required during the initialization process of a [`Device`].

Re: [WIP RFC v2 33/35] WIP: rust: drm/kms: Add VblankSupport

2024-12-05 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > This commit adds bindings for implementing vblank support for a driver's > CRTCs. These bindings are optional, to account for the fact that not all > drivers have dedicated hardware vblanks. > > In order to accomplish this, we introduc

[WIP RFC v2 33/35] WIP: rust: drm/kms: Add VblankSupport

2024-09-30 Thread Lyude Paul
This commit adds bindings for implementing vblank support for a driver's CRTCs. These bindings are optional, to account for the fact that not all drivers have dedicated hardware vblanks. In order to accomplish this, we introduce the VblankSupport trait which can be implemented on DriverCrtc by dri