Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-12 Thread Simona Vetter
On Wed, Dec 11, 2024 at 07:34:10PM -0500, Lyude Paul wrote: > On Wed, 2024-12-11 at 09:43 +0100, Simona Vetter wrote: > > On Tue, Dec 10, 2024 at 06:41:52PM -0500, Lyude Paul wrote: > > > On Tue, 2024-11-26 at 18:25 -0300, Daniel Almeida wrote: > > > > Hi Lyude, > > > > > > > > > On 30 Sep 2024, a

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-11 Thread Lyude Paul
On Wed, 2024-12-11 at 09:43 +0100, Simona Vetter wrote: > On Tue, Dec 10, 2024 at 06:41:52PM -0500, Lyude Paul wrote: > > On Tue, 2024-11-26 at 18:25 -0300, Daniel Almeida wrote: > > > Hi Lyude, > > > > > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > > > > > + > > > > +impl Connector {

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-11 Thread Simona Vetter
On Tue, Dec 10, 2024 at 06:41:52PM -0500, Lyude Paul wrote: > On Tue, 2024-11-26 at 18:25 -0300, Daniel Almeida wrote: > > Hi Lyude, > > > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > > > + > > > +impl Connector { > > > +/// Construct a new [`Connector`]. > > > +/// > > > +

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-10 Thread Lyude Paul
On Tue, 2024-11-26 at 18:25 -0300, Daniel Almeida wrote: > Hi Lyude, > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > + > > +impl Connector { > > +/// Construct a new [`Connector`]. > > +/// > > +/// A driver may use this to create new [`Connector`] objects. > > +/// > >

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-04 Thread Lyude Paul
On Wed, 2024-12-04 at 16:16 -0500, Lyude Paul wrote: > > At least the inputs must be valid. Speaking of which, are there any > > restrictions on `type_` ? > > type_ should actually be the constants that you were looking at before. In > retrospect we probably should make a custom enum for it, I th

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-12-04 Thread Lyude Paul
On Tue, 2024-11-26 at 18:25 -0300, Daniel Almeida wrote: > Hi Lyude, > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > We start off by introducing wrappers for the first important type of mode > > object: a DRM display connector. This introduces Connector > DriverConnector> and Connector

Re: [WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-11-26 Thread Daniel Almeida
Hi Lyude, > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > We start off by introducing wrappers for the first important type of mode > object: a DRM display connector. This introduces Connector DriverConnector> and ConnectorState. Both > DriverConnector and DriverConnectorState must be implemen

[WIP RFC v2 05/35] rust: drm/kms: Add bindings for drm_connector

2024-09-30 Thread Lyude Paul
We start off by introducing wrappers for the first important type of mode object: a DRM display connector. This introduces Connector and ConnectorState. Both DriverConnector and DriverConnectorState must be implemented by KMS drivers, and a driver may have as many implementations of these two trait