Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread jimqu
在 2018/7/16 22:16, Lukas Wunner 写道: On Mon, Jul 16, 2018 at 03:52:45PM +0800, Hui Wang wrote: On 2018???07???16??? 14:06, Jim Qu wrote: On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio codec for HDMP/DP output. For some dGPU which is no outp

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Lukas Wunner
On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote: > + > + list_for_each_entry(client, &vgasr_priv.clients, list) { > + if (!client_is_audio(client) || client_id(client) != > + VGA_SWITCHEROO_UNKNOWN_ID) Don't you have to check for client_id(client)

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Lukas Wunner
On Mon, Jul 16, 2018 at 04:47:11PM +0200, Takashi Iwai wrote: > On Mon, 16 Jul 2018 16:43:42 +0200, > Lukas Wunner wrote: > > > > On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote: > > > + > > > + list_for_each_entry(client, &vgasr_priv.clients, list) { > > > + if (!client_is_audio(cl

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Takashi Iwai
On Mon, 16 Jul 2018 16:43:42 +0200, Lukas Wunner wrote: > > On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote: > > + > > + list_for_each_entry(client, &vgasr_priv.clients, list) { > > + if (!client_is_audio(client) || client_id(client) != > > + VGA_SWITCHEROO_UNK

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Lukas Wunner
On Mon, Jul 16, 2018 at 03:52:45PM +0800, Hui Wang wrote: > On 2018???07???16??? 14:06, Jim Qu wrote: > >On modern laptop, there are more and more platforms > >have two GPUs, and each of them maybe have audio codec > >for HDMP/DP output. For some dGPU which is no output, > >audio codec usually is d

Re: [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Takashi Iwai
On Mon, 16 Jul 2018 08:06:35 +0200, Jim Qu wrote: > > On modern laptop, there are more and more platforms > have two GPUs, and each of them maybe have audio codec > for HDMP/DP output. For some dGPU which is no output, > audio codec usually is disabled. > > In currect HDA audio driver, it will se

[V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-15 Thread Jim Qu
On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio codec for HDMP/DP output. For some dGPU which is no output, audio codec usually is disabled. In currect HDA audio driver, it will set all codec as VGA_SWITCHEROO_DIS, the audio which is binded to U