Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-19 Thread Maxime Ripard
On Thu, Sep 14, 2023 at 03:29:16PM -0700, Doug Anderson wrote: > Hi, > > On Thu, Sep 14, 2023 at 1:14 AM Maxime Ripard wrote: > > > > > > So it doesn't have any relationship with the unbind/remove timing, and > > > > for all we know it can be there indefinitely, while the application > > > > cont

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-14 Thread Doug Anderson
Hi, On Thu, Sep 14, 2023 at 1:14 AM Maxime Ripard wrote: > > > > So it doesn't have any relationship with the unbind/remove timing, and > > > for all we know it can be there indefinitely, while the application > > > continues to interact with the driver. > > > > I spent some time thinking about s

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-14 Thread Maxime Ripard
Hi, On Wed, Sep 13, 2023 at 09:23:29AM -0700, Doug Anderson wrote: > On Wed, Sep 6, 2023 at 1:39 AM Maxime Ripard wrote: > > On Tue, Sep 05, 2023 at 01:16:08PM -0700, Doug Anderson wrote: > > > > > This commit is only compile-time tested. > > > > > > > > > > NOTE: this patch touches a lot more th

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-13 Thread Doug Anderson
Hi, On Fri, Sep 1, 2023 at 4:42 PM Douglas Anderson wrote: > > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powere

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-13 Thread Paul Cercueil
Hi Doug, Le mercredi 13 septembre 2023 à 09:25 -0700, Doug Anderson a écrit : > Hi, > > On Tue, Sep 5, 2023 at 1:16 PM Doug Anderson > wrote: > > > > Paul, > > > > On Mon, Sep 4, 2023 at 2:15 AM Paul Cercueil > > wrote: > > > > > > Hi Douglas, > > > > > > Le vendredi 01 septembre 2023 à 16:

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-13 Thread Doug Anderson
Hi, On Tue, Sep 5, 2023 at 1:16 PM Doug Anderson wrote: > > Paul, > > On Mon, Sep 4, 2023 at 2:15 AM Paul Cercueil wrote: > > > > Hi Douglas, > > > > Le vendredi 01 septembre 2023 à 16:41 -0700, Douglas Anderson a écrit : > > > Based on grepping through the source code this driver appears to be

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-13 Thread Doug Anderson
Hi, On Wed, Sep 6, 2023 at 1:39 AM Maxime Ripard wrote: > > On Tue, Sep 05, 2023 at 01:16:08PM -0700, Doug Anderson wrote: > > > > --- > > > > This commit is only compile-time tested. > > > > > > > > NOTE: this patch touches a lot more than other similar patches since > > > > the bind() function

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-06 Thread Maxime Ripard
On Tue, Sep 05, 2023 at 01:16:08PM -0700, Doug Anderson wrote: > > > --- > > > This commit is only compile-time tested. > > > > > > NOTE: this patch touches a lot more than other similar patches since > > > the bind() function is long and we want to make sure that we unset > > > the > > > drvdata i

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-05 Thread Doug Anderson
Paul, On Mon, Sep 4, 2023 at 2:15 AM Paul Cercueil wrote: > > Hi Douglas, > > Le vendredi 01 septembre 2023 à 16:41 -0700, Douglas Anderson a écrit : > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > t

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-04 Thread Paul Cercueil
Hi Douglas, Le vendredi 01 septembre 2023 à 16:41 -0700, Douglas Anderson a écrit : > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that > it >

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-04 Thread Maxime Ripard
On Fri, 1 Sep 2023 16:41:14 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered of

[RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-01 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call drm_atomic