Re: [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-23 Thread Niranjana Vishwanathapura
On Thu, Sep 22, 2022 at 12:54:09PM +0300, Jani Nikula wrote: On Wed, 21 Sep 2022, Niranjana Vishwanathapura wrote: diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer_common.h b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer_common.h new file mode 100644 index ..725febfd6a53 -

Re: [Intel-gfx] [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-22 Thread Niranjana Vishwanathapura
On Thu, Sep 22, 2022 at 10:05:34AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 19:17, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 11:18:53AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Two things: 1) Is there enough commonality to may

Re: [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Niranjana Vishwanathapura wrote: > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer_common.h > b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer_common.h > new file mode 100644 > index ..725febfd6a53 > --- /dev/null > +++ b/drivers/gpu/drm/i915/gem/i915_gem

Re: [Intel-gfx] [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-22 Thread Tvrtko Ursulin
On 21/09/2022 19:17, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 11:18:53AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between thes

Re: [Intel-gfx] [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-21 Thread Niranjana Vishwanathapura
On Wed, Sep 21, 2022 at 11:18:53AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between these two paths by abstracting out the common functionalities

Re: [Intel-gfx] [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-21 Thread Tvrtko Ursulin
On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between these two paths by abstracting out the common functionalities into a separate file where possible. Looks like a good start

[RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-21 Thread Niranjana Vishwanathapura
The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between these two paths by abstracting out the common functionalities into a separate file where possible. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/Makefile