Re: [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-07-04 Thread Karolina Stolarek
On 4.07.2023 09:01, Christian König wrote: Am 04.07.23 um 08:35 schrieb Karolina Stolarek: On 3.07.2023 13:21, Christian König wrote: Am 03.07.23 um 09:58 schrieb Karolina Stolarek: Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to

Re: [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-07-04 Thread Christian König
Am 04.07.23 um 08:35 schrieb Karolina Stolarek: On 3.07.2023 13:21, Christian König wrote: Am 03.07.23 um 09:58 schrieb Karolina Stolarek: Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test f

Re: [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-07-03 Thread Christian König
Am 04.07.23 um 08:50 schrieb Mauro Carvalho Chehab: On Mon, 3 Jul 2023 13:21:43 +0200 Christian König wrote: + /* We don't need this BO later, release it */ + ttm_bo_put(bo); That won't work. A BO must always outlive the TT object allocated for it. Otherwise you can get crashes d

Re: [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-07-03 Thread Mauro Carvalho Chehab
On Mon, 3 Jul 2023 13:21:43 +0200 Christian König wrote: > > + /* We don't need this BO later, release it */ > > + ttm_bo_put(bo); > > That won't work. A BO must always outlive the TT object allocated for it. > > Otherwise you can get crashes during TT release. Just my two cents: shouldn

Re: [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-07-03 Thread Karolina Stolarek
On 3.07.2023 13:21, Christian König wrote: Am 03.07.23 um 09:58 schrieb Karolina Stolarek: Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test for ttm_pool cleanup. Introduce helpers to create

Re: [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-07-03 Thread Christian König
Am 03.07.23 um 09:58 schrieb Karolina Stolarek: Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test for ttm_pool cleanup. Introduce helpers to create a dummy ttm_buffer_object. Signed-off-by:

[RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-07-03 Thread Karolina Stolarek
Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test for ttm_pool cleanup. Introduce helpers to create a dummy ttm_buffer_object. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/Mak