Re: [RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller

2025-01-22 Thread Krzysztof Kozlowski
On 21/01/2025 22:58, Michal Wilczynski wrote: >>> +maintainers: >>> + - Michal Wilczynski >>> + >>> +properties: >>> + compatible: >>> +enum: >>> + - thead,th1520-reset >>> + >>> + reg: >>> +maxItems: 1 >>> + >>> + "#reset-cells": >>> +const: 0 >> >> Should this be "const: 1"

Re: [RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller

2025-01-21 Thread Michal Wilczynski
On 1/21/25 09:35, Philipp Zabel wrote: > On Mo, 2025-01-20 at 18:21 +0100, Michal Wilczynski wrote: >> Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This >> controller manages resets for subsystems such as the GPU within the >> TH1520 SoC. > > This mentions "resets", plural, but

Re: [RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller

2025-01-21 Thread Philipp Zabel
On Mo, 2025-01-20 at 18:21 +0100, Michal Wilczynski wrote: > Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This > controller manages resets for subsystems such as the GPU within the > TH1520 SoC. This mentions "resets", plural, but the #reset-cells = <0> below and the driver implem

[RFC v3 07/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller

2025-01-20 Thread Michal Wilczynski
Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This controller manages resets for subsystems such as the GPU within the TH1520 SoC. Signed-off-by: Michal Wilczynski --- .../bindings/reset/thead,th1520-reset.yaml| 44 +++ MAINTAINERS