[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Thierry Reding
On Fri, Dec 07, 2012 at 09:30:34AM +0100, Daniel Vetter wrote: > On Fri, Dec 7, 2012 at 8:28 AM, Thierry Reding > wrote: > > On Thu, Dec 06, 2012 at 02:55:23PM -0200, Paulo Zanoni wrote: > >> 2012/12/6 Paulo Zanoni : > >> For the changes inside intel_hdmi.c, I'd really like your patch to not > >>

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Daniel Vetter
On Fri, Dec 7, 2012 at 8:28 AM, Thierry Reding wrote: > On Thu, Dec 06, 2012 at 02:55:23PM -0200, Paulo Zanoni wrote: >> 2012/12/6 Paulo Zanoni : >> For the changes inside intel_hdmi.c, I'd really like your patch to not >> touch any of the "write_infoframe" or "set_infoframes" callbacks. I >> thin

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Thierry Reding
On Thu, Dec 06, 2012 at 02:55:23PM -0200, Paulo Zanoni wrote: > Hi > > 2012/12/6 Paulo Zanoni : > > Hi > > > > 2012/12/5 Thierry Reding : > >> Use the generic HDMI infoframe helpers to get rid of the duplicate > >> implementation in the i915 driver. > > > > A few comments: > > > > - I've compiled

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Thierry Reding
On Thu, Dec 06, 2012 at 02:11:00PM -0200, Paulo Zanoni wrote: > Hi > > 2012/12/5 Thierry Reding : > > Use the generic HDMI infoframe helpers to get rid of the duplicate > > implementation in the i915 driver. > > A few comments: > > - I've compiled your patches and now "intel_infoframes -d" tells

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Thierry Reding
On Fri, Dec 07, 2012 at 09:30:34AM +0100, Daniel Vetter wrote: > On Fri, Dec 7, 2012 at 8:28 AM, Thierry Reding > wrote: > > On Thu, Dec 06, 2012 at 02:55:23PM -0200, Paulo Zanoni wrote: > >> 2012/12/6 Paulo Zanoni : > >> For the changes inside intel_hdmi.c, I'd really like your patch to not > >>

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Daniel Vetter
On Fri, Dec 7, 2012 at 8:28 AM, Thierry Reding wrote: > On Thu, Dec 06, 2012 at 02:55:23PM -0200, Paulo Zanoni wrote: >> 2012/12/6 Paulo Zanoni : >> For the changes inside intel_hdmi.c, I'd really like your patch to not >> touch any of the "write_infoframe" or "set_infoframes" callbacks. I >> thin

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 02:55:23PM -0200, Paulo Zanoni wrote: > Hi > > 2012/12/6 Paulo Zanoni : > > Hi > > > > 2012/12/5 Thierry Reding : > >> Use the generic HDMI infoframe helpers to get rid of the duplicate > >> implementation in the i915 driver. > > > > A few comments: > > > > - I've compiled

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 02:11:00PM -0200, Paulo Zanoni wrote: > Hi > > 2012/12/5 Thierry Reding : > > Use the generic HDMI infoframe helpers to get rid of the duplicate > > implementation in the i915 driver. > > A few comments: > > - I've compiled your patches and now "intel_infoframes -d" tells

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 04:57:27PM +0100, Daniel Vetter wrote: > On Thu, Dec 6, 2012 at 3:23 PM, Thierry Reding > wrote: > >> > - /* sdvo spec says that the ecc is handled by the hw, and it looks > >> > like > >> > -* we must not send the ecc field, either. */ > >> > - memcpy(sdvo_data, &

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Daniel Vetter
On Thu, Dec 6, 2012 at 3:23 PM, Thierry Reding wrote: >> > - /* sdvo spec says that the ecc is handled by the hw, and it looks like >> > -* we must not send the ecc field, either. */ >> > - memcpy(sdvo_data, &avi_if, 3); >> > - sdvo_data[3] = avi_if.checksum; >> >> This difference betwee

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 03:16:31PM +0100, Daniel Vetter wrote: > On Wed, Dec 05, 2012 at 05:45:44PM +0100, Thierry Reding wrote: > > Use the generic HDMI infoframe helpers to get rid of the duplicate > > implementation in the i915 driver. > > > > Signed-off-by: Thierry Reding > > > diff --git a/

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Daniel Vetter
On Wed, Dec 05, 2012 at 05:45:44PM +0100, Thierry Reding wrote: > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. > > Signed-off-by: Thierry Reding > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c > b/drivers/gpu/drm/i915/intel_sdvo.c > in

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Paulo Zanoni
Hi 2012/12/6 Paulo Zanoni : > Hi > > 2012/12/5 Thierry Reding : >> Use the generic HDMI infoframe helpers to get rid of the duplicate >> implementation in the i915 driver. > > A few comments: > > - I've compiled your patches and now "intel_infoframes -d" tells my my > infoframes are full of zeroes

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Paulo Zanoni
Hi 2012/12/5 Thierry Reding : > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. A few comments: - I've compiled your patches and now "intel_infoframes -d" tells my my infoframes are full of zeroes. So there's a bug somewhere... I have to sa

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Paulo Zanoni
Hi 2012/12/6 Paulo Zanoni : > Hi > > 2012/12/5 Thierry Reding : >> Use the generic HDMI infoframe helpers to get rid of the duplicate >> implementation in the i915 driver. > > A few comments: > > - I've compiled your patches and now "intel_infoframes -d" tells my my > infoframes are full of zeroes

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Paulo Zanoni
Hi 2012/12/5 Thierry Reding : > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. A few comments: - I've compiled your patches and now "intel_infoframes -d" tells my my infoframes are full of zeroes. So there's a bug somewhere... I have to sa

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 04:57:27PM +0100, Daniel Vetter wrote: > On Thu, Dec 6, 2012 at 3:23 PM, Thierry Reding > wrote: > >> > - /* sdvo spec says that the ecc is handled by the hw, and it looks > >> > like > >> > -* we must not send the ecc field, either. */ > >> > - memcpy(sdvo_data, &

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Daniel Vetter
On Thu, Dec 6, 2012 at 3:23 PM, Thierry Reding wrote: >> > - /* sdvo spec says that the ecc is handled by the hw, and it looks like >> > -* we must not send the ecc field, either. */ >> > - memcpy(sdvo_data, &avi_if, 3); >> > - sdvo_data[3] = avi_if.checksum; >> >> This difference betwee

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 03:16:31PM +0100, Daniel Vetter wrote: > On Wed, Dec 05, 2012 at 05:45:44PM +0100, Thierry Reding wrote: > > Use the generic HDMI infoframe helpers to get rid of the duplicate > > implementation in the i915 driver. > > > > Signed-off-by: Thierry Reding > > > diff --git a/

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Daniel Vetter
On Wed, Dec 05, 2012 at 05:45:44PM +0100, Thierry Reding wrote: > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. > > Signed-off-by: Thierry Reding > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c > b/drivers/gpu/drm/i915/intel_sdvo.c > in

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-05 Thread Thierry Reding
Use the generic HDMI infoframe helpers to get rid of the duplicate implementation in the i915 driver. Signed-off-by: Thierry Reding --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/i915/intel_drv.h | 62 + drivers/gpu/drm/i915/intel_hdmi.c | 268 +-

[RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-05 Thread Thierry Reding
Use the generic HDMI infoframe helpers to get rid of the duplicate implementation in the i915 driver. Signed-off-by: Thierry Reding --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/i915/intel_drv.h | 62 + drivers/gpu/drm/i915/intel_hdmi.c | 268 +-