[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-07 Thread Daniel Vetter
On Wed, Dec 05, 2012 at 05:45:42PM +0100, Thierry Reding wrote: > Add a generic helper to fill in an HDMI AVI infoframe with data > extracted from a DRM display mode. > > Signed-off-by: Thierry Reding > +/** > + * drm_hdmi_avi_infoframe_from_display_mode() - fill an HDMI AVI infoframe > with >

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-07 Thread Daniel Vetter
On Wed, Dec 05, 2012 at 05:45:42PM +0100, Thierry Reding wrote: > Add a generic helper to fill in an HDMI AVI infoframe with data > extracted from a DRM display mode. > > Signed-off-by: Thierry Reding > +/** > + * drm_hdmi_avi_infoframe_from_display_mode() - fill an HDMI AVI infoframe > with >

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 04:44:38PM +0100, Daniel Vetter wrote: > On Thu, Dec 6, 2012 at 3:28 PM, Thierry Reding > wrote: > >> Note that the intel avi infoframe in intel_hdmi_set_avi_infoframe also > >> sets the pixel repeat for double clocked modes with: > >> > >> if (adjusted_mode->flags &

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Daniel Vetter
On Thu, Dec 6, 2012 at 3:28 PM, Thierry Reding wrote: >> Note that the intel avi infoframe in intel_hdmi_set_avi_infoframe also >> sets the pixel repeat for double clocked modes with: >> >> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK) >> avi_if.body.avi.YQ_CN_PR |= DIP_AVI_

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 03:09:00PM +0100, Daniel Vetter wrote: > On Wed, Dec 05, 2012 at 05:45:42PM +0100, Thierry Reding wrote: [...] > > diff --git a/drivers/gpu/drm/drm_hdmi.c b/drivers/gpu/drm/drm_hdmi.c > > new file mode 100644 > > index 000..821ca56 > > --- /dev/null > > +++ b/drivers/gpu

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Daniel Vetter
On Wed, Dec 05, 2012 at 05:45:42PM +0100, Thierry Reding wrote: > Add a generic helper to fill in an HDMI AVI infoframe with data > extracted from a DRM display mode. > > Signed-off-by: Thierry Reding A few quick comments below. > --- > Changes in v2: > - reuse CEA modes defined in drm_edid_mod

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Lars-Peter Clausen
On 12/06/2012 08:28 AM, Thierry Reding wrote: > On Wed, Dec 05, 2012 at 06:51:20PM +0100, Lars-Peter Clausen wrote: >> On 12/05/2012 05:45 PM, Thierry Reding wrote: >>> Add a generic helper to fill in an HDMI AVI infoframe with data >>> extracted from a DRM display mode. >> >> That's a very nice pa

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Wed, Dec 05, 2012 at 06:51:20PM +0100, Lars-Peter Clausen wrote: > On 12/05/2012 05:45 PM, Thierry Reding wrote: > > Add a generic helper to fill in an HDMI AVI infoframe with data > > extracted from a DRM display mode. > > That's a very nice patch series, comes in pretty handy. Thanks :) > >

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 04:44:38PM +0100, Daniel Vetter wrote: > On Thu, Dec 6, 2012 at 3:28 PM, Thierry Reding > wrote: > >> Note that the intel avi infoframe in intel_hdmi_set_avi_infoframe also > >> sets the pixel repeat for double clocked modes with: > >> > >> if (adjusted_mode->flags &

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Daniel Vetter
On Thu, Dec 6, 2012 at 3:28 PM, Thierry Reding wrote: >> Note that the intel avi infoframe in intel_hdmi_set_avi_infoframe also >> sets the pixel repeat for double clocked modes with: >> >> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK) >> avi_if.body.avi.YQ_CN_PR |= DIP_AVI_

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Thu, Dec 06, 2012 at 03:09:00PM +0100, Daniel Vetter wrote: > On Wed, Dec 05, 2012 at 05:45:42PM +0100, Thierry Reding wrote: [...] > > diff --git a/drivers/gpu/drm/drm_hdmi.c b/drivers/gpu/drm/drm_hdmi.c > > new file mode 100644 > > index 000..821ca56 > > --- /dev/null > > +++ b/drivers/gpu

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Daniel Vetter
On Wed, Dec 05, 2012 at 05:45:42PM +0100, Thierry Reding wrote: > Add a generic helper to fill in an HDMI AVI infoframe with data > extracted from a DRM display mode. > > Signed-off-by: Thierry Reding A few quick comments below. > --- > Changes in v2: > - reuse CEA modes defined in drm_edid_mod

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Lars-Peter Clausen
On 12/06/2012 08:28 AM, Thierry Reding wrote: > On Wed, Dec 05, 2012 at 06:51:20PM +0100, Lars-Peter Clausen wrote: >> On 12/05/2012 05:45 PM, Thierry Reding wrote: >>> Add a generic helper to fill in an HDMI AVI infoframe with data >>> extracted from a DRM display mode. >> >> That's a very nice pa

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-06 Thread Thierry Reding
On Wed, Dec 05, 2012 at 06:51:20PM +0100, Lars-Peter Clausen wrote: > On 12/05/2012 05:45 PM, Thierry Reding wrote: > > Add a generic helper to fill in an HDMI AVI infoframe with data > > extracted from a DRM display mode. > > That's a very nice patch series, comes in pretty handy. Thanks :) > >

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-05 Thread Lars-Peter Clausen
On 12/05/2012 05:45 PM, Thierry Reding wrote: > Add a generic helper to fill in an HDMI AVI infoframe with data > extracted from a DRM display mode. That's a very nice patch series, comes in pretty handy. Thanks :) I've just one comment. > [...] > +static inline enum hdmi_picture_aspect > +drm_d

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-05 Thread Thierry Reding
Add a generic helper to fill in an HDMI AVI infoframe with data extracted from a DRM display mode. Signed-off-by: Thierry Reding --- Changes in v2: - reuse CEA modes defined in drm_edid_modes.h drivers/gpu/drm/Kconfig| 7 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_hdmi.c

Re: [RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-05 Thread Lars-Peter Clausen
On 12/05/2012 05:45 PM, Thierry Reding wrote: > Add a generic helper to fill in an HDMI AVI infoframe with data > extracted from a DRM display mode. That's a very nice patch series, comes in pretty handy. Thanks :) I've just one comment. > [...] > +static inline enum hdmi_picture_aspect > +drm_d

[RFC v2 3/5] drm: Add HDMI infoframe helpers

2012-12-05 Thread Thierry Reding
Add a generic helper to fill in an HDMI AVI infoframe with data extracted from a DRM display mode. Signed-off-by: Thierry Reding --- Changes in v2: - reuse CEA modes defined in drm_edid_modes.h drivers/gpu/drm/Kconfig| 7 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_hdmi.c