Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-12 Thread Daniel Vetter
On Thu, May 12, 2022 at 03:28:16PM +0200, Tomeu Vizoso wrote: > On 5/11/22 7:46 PM, Rob Clark wrote: > > On Wed, May 11, 2022 at 10:12 AM Daniel Vetter wrote: > > > > > > On Tue, 10 May 2022 at 22:26, Rob Clark wrote: > > > > > > > > On Tue, May 10, 2022 at 12:39 PM Jessica Zhang > > > > wrote

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-12 Thread Tomeu Vizoso
On 5/11/22 7:46 PM, Rob Clark wrote: On Wed, May 11, 2022 at 10:12 AM Daniel Vetter wrote: On Tue, 10 May 2022 at 22:26, Rob Clark wrote: On Tue, May 10, 2022 at 12:39 PM Jessica Zhang wrote: On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: And use it to store expectations about what the drm

Re: [Freedreno] Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Theodore Ts'o
On Wed, May 11, 2022 at 06:33:32AM -0700, Rob Clark wrote: > > And ofc we want the expectations to be in the kernel tree because > there could be, for example, differences between -fixes and -next > branches. (Or even stable kernel branches if/when we get to the point > of running CI on those.)

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Daniel Vetter
On Wed, 11 May 2022 at 22:32, Rob Clark wrote: > > On Wed, May 11, 2022 at 12:14 PM Daniel Vetter wrote: > > > > On Wed, 11 May 2022 at 19:46, Rob Clark wrote: > > > > > > On Wed, May 11, 2022 at 10:12 AM Daniel Vetter wrote: > > > > > > > > On Tue, 10 May 2022 at 22:26, Rob Clark wrote: > > >

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Rob Clark
On Wed, May 11, 2022 at 12:14 PM Daniel Vetter wrote: > > On Wed, 11 May 2022 at 19:46, Rob Clark wrote: > > > > On Wed, May 11, 2022 at 10:12 AM Daniel Vetter wrote: > > > > > > On Tue, 10 May 2022 at 22:26, Rob Clark wrote: > > > > > > > > On Tue, May 10, 2022 at 12:39 PM Jessica Zhang > > >

Re: [Freedreno] Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Rob Clark
On Wed, May 11, 2022 at 12:12 PM Linus Torvalds wrote: > > On Wed, May 11, 2022 at 12:08 PM Linus Torvalds > wrote: > > > > The kernel tree might have just the expected *failures* listed, if > > there are any. Presumably the ci tree has to have the expected results > > anyway, so what's the advan

Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Rob Clark
On Wed, May 11, 2022 at 12:08 PM Linus Torvalds wrote: > > On Wed, May 11, 2022 at 11:40 AM Rob Clark wrote: > > > > It is missing in this revision of the RFC, but the intention is to > > have the gitlab-ci.yml point to a specific commit SHA in the > > gfx-ci/drm-ci[1] tree, to solve the problem

Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Daniel Vetter
On Wed, May 11, 2022 at 10:33:06AM -0700, Linus Torvalds wrote: > On Tue, May 10, 2022 at 10:07 PM Dave Airlie wrote: > > > > > And use it to store expectations about what the drm/msm driver is > > > supposed to pass in the IGT test suite. > > > > I wanted to loop in Linus/Greg to see if there are

Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Linus Torvalds
On Wed, May 11, 2022 at 12:08 PM Linus Torvalds wrote: > > The kernel tree might have just the expected *failures* listed, if > there are any. Presumably the ci tree has to have the expected results > anyway, so what's the advantage of listing non-failures? .. put another way: I think a list of "

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Daniel Vetter
On Wed, 11 May 2022 at 19:46, Rob Clark wrote: > > On Wed, May 11, 2022 at 10:12 AM Daniel Vetter wrote: > > > > On Tue, 10 May 2022 at 22:26, Rob Clark wrote: > > > > > > On Tue, May 10, 2022 at 12:39 PM Jessica Zhang > > > wrote: > > > > > > > > > > > > > > > > On 5/10/2022 7:13 AM, Tomeu Viz

Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Linus Torvalds
On Wed, May 11, 2022 at 11:40 AM Rob Clark wrote: > > It is missing in this revision of the RFC, but the intention is to > have the gitlab-ci.yml point to a specific commit SHA in the > gfx-ci/drm-ci[1] tree, to solve the problem of keeping the results in > sync with the expectations. Ie. a kerne

Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Rob Clark
On Wed, May 11, 2022 at 10:33 AM Linus Torvalds wrote: > > On Tue, May 10, 2022 at 10:07 PM Dave Airlie wrote: > > > > > And use it to store expectations about what the drm/msm driver is > > > supposed to pass in the IGT test suite. > > > > I wanted to loop in Linus/Greg to see if there are any i

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Rob Clark
On Wed, May 11, 2022 at 10:12 AM Daniel Vetter wrote: > > On Tue, 10 May 2022 at 22:26, Rob Clark wrote: > > > > On Tue, May 10, 2022 at 12:39 PM Jessica Zhang > > wrote: > > > > > > > > > > > > On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: > > > > And use it to store expectations about what the drm

Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Linus Torvalds
On Tue, May 10, 2022 at 10:07 PM Dave Airlie wrote: > > > And use it to store expectations about what the drm/msm driver is > > supposed to pass in the IGT test suite. > > I wanted to loop in Linus/Greg to see if there are any issues raised > by adding CI results file to the tree in their minds, o

Re: [Freedreno] Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Rob Clark
On Wed, May 11, 2022 at 9:43 AM Daniel Vetter wrote: > > On Wed, 11 May 2022 at 15:33, Rob Clark wrote: > > On Wed, May 11, 2022 at 4:50 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, May 11, 2022 at 12:26:05PM +0200, Michel Dänzer wrote: > > > > On 2022-05-11 08:22, Greg Kroah-Hartman wro

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Daniel Vetter
On Tue, 10 May 2022 at 22:26, Rob Clark wrote: > > On Tue, May 10, 2022 at 12:39 PM Jessica Zhang > wrote: > > > > > > > > On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: > > > And use it to store expectations about what the drm/msm driver is > > > supposed to pass in the IGT test suite. > > > > > > Al

Re: [Freedreno] Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Daniel Vetter
On Wed, 11 May 2022 at 15:33, Rob Clark wrote: > On Wed, May 11, 2022 at 4:50 AM Greg Kroah-Hartman > wrote: > > > > On Wed, May 11, 2022 at 12:26:05PM +0200, Michel Dänzer wrote: > > > On 2022-05-11 08:22, Greg Kroah-Hartman wrote: > > > > On Wed, May 11, 2022 at 03:06:47PM +1000, Dave Airlie wr

Re: [Freedreno] Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Rob Clark
On Wed, May 11, 2022 at 4:50 AM Greg Kroah-Hartman wrote: > > On Wed, May 11, 2022 at 12:26:05PM +0200, Michel Dänzer wrote: > > On 2022-05-11 08:22, Greg Kroah-Hartman wrote: > > > On Wed, May 11, 2022 at 03:06:47PM +1000, Dave Airlie wrote: > > >>> And use it to store expectations about what the

Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-11 Thread Greg Kroah-Hartman
On Wed, May 11, 2022 at 12:26:05PM +0200, Michel Dänzer wrote: > On 2022-05-11 08:22, Greg Kroah-Hartman wrote: > > On Wed, May 11, 2022 at 03:06:47PM +1000, Dave Airlie wrote: > >>> And use it to store expectations about what the drm/msm driver is > >>> supposed to pass in the IGT test suite. > >>

Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Greg Kroah-Hartman
On Wed, May 11, 2022 at 03:06:47PM +1000, Dave Airlie wrote: > > And use it to store expectations about what the drm/msm driver is > > supposed to pass in the IGT test suite. > > I wanted to loop in Linus/Greg to see if there are any issues raised > by adding CI results file to the tree in their m

Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Dave Airlie
> And use it to store expectations about what the drm/msm driver is > supposed to pass in the IGT test suite. I wanted to loop in Linus/Greg to see if there are any issues raised by adding CI results file to the tree in their minds, or if any other subsystem has done this already, and it's all fin

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
On 5/10/22 9:39 PM, Jessica Zhang wrote: On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: +igt@kms_atomic_interruptible@legacy-setmode@pipe-a-edp-1 +igt@kms_atomic_interruptible@atomic-setmode@pipe-a-edp-1 +igt@kms_atomic_interruptible@legacy-dpms@pipe-a-edp-1 +igt@kms_atomic_interruptible@legacy-pag

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Rob Clark
On Tue, May 10, 2022 at 12:39 PM Jessica Zhang wrote: > > > > On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: > > And use it to store expectations about what the drm/msm driver is > > supposed to pass in the IGT test suite. > > > > Also include a configuration file that points to the out-of-tree CI > >

Re: [Freedreno] [RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Jessica Zhang
On 5/10/2022 7:13 AM, Tomeu Vizoso wrote: And use it to store expectations about what the drm/msm driver is supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the test expectations along the code we can make sure bo

[RFC v2] drm/msm: Add initial ci/ subdirectory

2022-05-10 Thread Tomeu Vizoso
And use it to store expectations about what the drm/msm driver is supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the test expectations along the code we can make sure both stay in sync with each other, and so we can