Re: [RFC PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-17 Thread Aditya Garg
Hi Thomas > On 17 Feb 2025, at 1:34 PM, Thomas Zimmermann wrote: > > Hi Aditya, > > the code looks correct overall. There's one place where I think it fails. See > below. > > Am 15.02.25 um 14:43 schrieb Aditya Garg: > [...] >> DEFINE_DRM_GEM_FOPS(appletbdrm_drm_fops); >> @@ -484,10 +537,38

Re: [RFC PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-17 Thread Thomas Zimmermann
Hi Aditya, the code looks correct overall. There's one place where I think it fails. See below. Am 15.02.25 um 14:43 schrieb Aditya Garg: [...] DEFINE_DRM_GEM_FOPS(appletbdrm_drm_fops); @@ -484,10 +537,38 @@ static const struct drm_driver appletbdrm_drm_driver = { static int appletbdrm_setup_

Re: [RFC PATCH v5 10/10] drm/tiny: add driver for Apple Touch Bars in x86 Macs

2025-02-15 Thread Aditya Garg
Hi Thomas >> From: Kerem Karabay >> >> The Touch Bars found on x86 Macs support two USB configurations: one >> where the device presents itself as a HID keyboard and can display >> predefined sets of keys, and one where the operating system has full >> control over what is displayed. This commit