Re: [RFC PATCH 2/3] drm/virtio: new fence for every plane update

2023-08-20 Thread Kim, Dongwon
On 8/17/2023 7:21 PM, Dmitry Osipenko wrote: ... +static struct +drm_plane_state *virtio_gpu_plane_duplicate_state(struct drm_plane *plane) +{ + struct virtio_gpu_plane_state *new; + + if (WARN_ON(!plane->state)) + return NULL; When plane->state can be NULL? Honestly

Re: [RFC PATCH 2/3] drm/virtio: new fence for every plane update

2023-08-17 Thread Dmitry Osipenko
... > +static struct > +drm_plane_state *virtio_gpu_plane_duplicate_state(struct drm_plane *plane) > +{ > + struct virtio_gpu_plane_state *new; > + > + if (WARN_ON(!plane->state)) > + return NULL; When plane->state can be NULL? > + new = kzalloc(sizeof(*new), GFP_KERNEL);

[RFC PATCH 2/3] drm/virtio: new fence for every plane update

2023-07-12 Thread Dongwon Kim
Having a fence linked to a virtio_gpu_framebuffer in plane update sequence would cause conflict when several planes referencing the same framebuffer especially when those planes are updated concurrently (e.g. Xorg screen covering multi-displays configured for an extended mode). So it is better for

[RFC PATCH 2/3] drm/virtio: new fence for every plane update

2022-09-26 Thread Dongwon Kim
Having a fence linked to a virtio_gpu_framebuffer in plane update sequence would cause conflict when several planes referencing the same framebuffer especially when those planes are updated concurrently (e.g. Xorg screen covering multi-displays configured for an extended mode). So it is better for