Re: [RFC PATCH 1/3] drm/msm/dp: fold disable_irq into devm_request_irq

2022-09-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-09-01 02:15:25) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index bfd0aeff3f0d..3173e6962a78 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1251,13 +1251,12 @@ int

[RFC PATCH 1/3] drm/msm/dp: fold disable_irq into devm_request_irq

2022-09-01 Thread Dmitry Baryshkov
Calling disable_irq() right after devm_request_irq() is a bad practice. it leaves a small window when the driver doesn't expect the IRQ, but the hardware still can trigger it. Use the IRQF_NO_AUTOEN flag to prevent the request_irq from enabling the IRQ line. Signed-off-by: Dmitry Baryshkov --- d