Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-16 Thread Lyude Paul
On Sat, 2021-02-13 at 10:26 +, Almahallawy, Khaled wrote: > On Fri, 2021-02-12 at 21:01 -0500, Lyude Paul wrote: > > (adding danvet to here, as I'd imagine they might be interested in > > seeing some > > of this) > > > > Thank you for the descriptive write up. I think we can solve some of > >

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-13 Thread Almahallawy, Khaled
On Fri, 2021-02-12 at 21:01 -0500, Lyude Paul wrote: > (adding danvet to here, as I'd imagine they might be interested in > seeing some > of this) > > Thank you for the descriptive write up. I think we can solve some of > the > problems you described here, however the patches that you submitted >

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-12 Thread Lyude Paul
(adding danvet to here, as I'd imagine they might be interested in seeing some of this) Thank you for the descriptive write up. I think we can solve some of the problems you described here, however the patches that you submitted definitely won't work as-is. In patch 2, by reverting Intel back to u

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-11 Thread Lyude Paul
(JFYI I have seen this email, but haven't gotten a chance to actually read through it yet. I should have the time to do so tomorrow) On Thu, 2021-02-11 at 06:56 +, Almahallawy, Khaled wrote: > On Wed, 2021-02-10 at 13:03 -0500, Lyude Paul wrote: > > On Wed, 2021-02-10 at 00:33 -0800, Khaled Al

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Almahallawy, Khaled
On Wed, 2021-02-10 at 13:03 -0500, Lyude Paul wrote: > On Wed, 2021-02-10 at 00:33 -0800, Khaled Almahallawy wrote: > > The number of AUX retries specified in the DP specs is 7. > > Currently, to make > > Dell 4k monitors happier, the number of retries are 32. > > i915 also retries 5 times (intel_d

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Lyude Paul
On Wed, 2021-02-10 at 00:33 -0800, Khaled Almahallawy wrote: > The number of AUX retries specified in the DP specs is 7. Currently, to make > Dell 4k monitors happier, the number of retries are 32. > i915 also retries 5 times (intel_dp_aux_xfer) which means in the case of AUX > timeout we actually

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Almahallawy, Khaled
On Wed, 2021-02-10 at 09:55 +0100, Thomas Zimmermann wrote: > Hi > > Am 10.02.21 um 09:33 schrieb Khaled Almahallawy: > > The number of AUX retries specified in the DP specs is 7. > > Currently, to make Dell 4k monitors happier, the number of retries > > are 32. > > i915 also retries 5 times (inte

Re: [RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Thomas Zimmermann
Hi Am 10.02.21 um 09:33 schrieb Khaled Almahallawy: The number of AUX retries specified in the DP specs is 7. Currently, to make Dell 4k monitors happier, the number of retries are 32. i915 also retries 5 times (intel_dp_aux_xfer) which means in the case of AUX timeout we actually retries 32 *

[RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Khaled Almahallawy
The number of AUX retries specified in the DP specs is 7. Currently, to make Dell 4k monitors happier, the number of retries are 32. i915 also retries 5 times (intel_dp_aux_xfer) which means in the case of AUX timeout we actually retries 32 * 5 = 160 times. So making the number of aux retires a