Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-24 Thread Boris Brezillon
Hi Maxime, On Thu, 20 Feb 2025 14:32:14 +0100 Maxime Ripard wrote: > > > > This approach has two downsides though: > > > > > > > > 1. We have no way of checking that the memory we're passed is actually > > > > suitable for FW execution in a protected context. If we're passed > > > > random memo

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-20 Thread Maxime Ripard
On Tue, Feb 11, 2025 at 03:32:23PM +0100, Boris Brezillon wrote: > On Tue, 11 Feb 2025 14:46:56 +0100 > Maxime Ripard wrote: > > > Hi Boris, > > > > On Fri, Feb 07, 2025 at 04:02:53PM +0100, Boris Brezillon wrote: > > > Sorry for joining the party late, a couple of comments to back Akash > > > a

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-11 Thread Boris Brezillon
On Tue, 11 Feb 2025 14:46:56 +0100 Maxime Ripard wrote: > Hi Boris, > > On Fri, Feb 07, 2025 at 04:02:53PM +0100, Boris Brezillon wrote: > > Sorry for joining the party late, a couple of comments to back Akash > > and Nicolas' concerns. > > > > On Wed, 05 Feb 2025 13:14:14 -0500 > > Nicolas Duf

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-11 Thread Maxime Ripard
Hi Boris, On Fri, Feb 07, 2025 at 04:02:53PM +0100, Boris Brezillon wrote: > Sorry for joining the party late, a couple of comments to back Akash > and Nicolas' concerns. > > On Wed, 05 Feb 2025 13:14:14 -0500 > Nicolas Dufresne wrote: > > > Le mercredi 05 février 2025 à 15:52 +0100, Maxime Rip

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-07 Thread Boris Brezillon
On Fri, 07 Feb 2025 11:32:18 -0500 Nicolas Dufresne wrote: > Le vendredi 07 février 2025 à 16:02 +0100, Boris Brezillon a écrit : > > Sorry for joining the party late, a couple of comments to back Akash > > and Nicolas' concerns. > > > > On Wed, 05 Feb 2025 13:14:14 -0500 > > Nicolas Dufresne w

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-07 Thread Nicolas Dufresne
Le vendredi 07 février 2025 à 16:02 +0100, Boris Brezillon a écrit : > Sorry for joining the party late, a couple of comments to back Akash > and Nicolas' concerns. > > On Wed, 05 Feb 2025 13:14:14 -0500 > Nicolas Dufresne wrote: > > > Le mercredi 05 février 2025 à 15:52 +0100, Maxime Ripard a é

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-07 Thread Boris Brezillon
Sorry for joining the party late, a couple of comments to back Akash and Nicolas' concerns. On Wed, 05 Feb 2025 13:14:14 -0500 Nicolas Dufresne wrote: > Le mercredi 05 février 2025 à 15:52 +0100, Maxime Ripard a écrit : > > On Mon, Feb 03, 2025 at 04:43:23PM +, Florent Tomasin wrote: > > >

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-05 Thread Nicolas Dufresne
Le mercredi 05 février 2025 à 15:52 +0100, Maxime Ripard a écrit : > On Mon, Feb 03, 2025 at 04:43:23PM +, Florent Tomasin wrote: > > Hi Maxime, Nicolas > > > > On 30/01/2025 17:47, Nicolas Dufresne wrote: > > > Le jeudi 30 janvier 2025 à 17:38 +0100, Maxime Ripard a écrit : > > > > Hi Nicolas

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-05 Thread Nicolas Dufresne
Le mercredi 05 février 2025 à 15:53 +0100, Maxime Ripard a écrit : > On Tue, Feb 04, 2025 at 01:22:58PM -0500, Nicolas Dufresne wrote: > > Le lundi 03 février 2025 à 16:43 +, Florent Tomasin a écrit : > > > Hi Maxime, Nicolas > > > > > > On 30/01/2025 17:47, Nicolas Dufresne wrote: > > > > Le

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-05 Thread Maxime Ripard
On Mon, Feb 03, 2025 at 04:43:23PM +, Florent Tomasin wrote: > Hi Maxime, Nicolas > > On 30/01/2025 17:47, Nicolas Dufresne wrote: > > Le jeudi 30 janvier 2025 à 17:38 +0100, Maxime Ripard a écrit : > >> Hi Nicolas, > >> > >> On Thu, Jan 30, 2025 at 10:59:56AM -0500, Nicolas Dufresne wrote: >

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-05 Thread Maxime Ripard
On Tue, Feb 04, 2025 at 01:22:58PM -0500, Nicolas Dufresne wrote: > Le lundi 03 février 2025 à 16:43 +, Florent Tomasin a écrit : > > Hi Maxime, Nicolas > > > > On 30/01/2025 17:47, Nicolas Dufresne wrote: > > > Le jeudi 30 janvier 2025 à 17:38 +0100, Maxime Ripard a écrit : > > > > Hi Nicolas

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-04 Thread Nicolas Dufresne
Le lundi 03 février 2025 à 16:43 +, Florent Tomasin a écrit : > Hi Maxime, Nicolas > > On 30/01/2025 17:47, Nicolas Dufresne wrote: > > Le jeudi 30 janvier 2025 à 17:38 +0100, Maxime Ripard a écrit : > > > Hi Nicolas, > > > > > > On Thu, Jan 30, 2025 at 10:59:56AM -0500, Nicolas Dufresne wrot

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-03 Thread Florent Tomasin
Hi Maxime, Nicolas On 30/01/2025 17:47, Nicolas Dufresne wrote: > Le jeudi 30 janvier 2025 à 17:38 +0100, Maxime Ripard a écrit : >> Hi Nicolas, >> >> On Thu, Jan 30, 2025 at 10:59:56AM -0500, Nicolas Dufresne wrote: >>> Le jeudi 30 janvier 2025 à 14:46 +0100, Maxime Ripard a écrit : Hi,

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-02-03 Thread Boris Brezillon
On Thu, 30 Jan 2025 17:15:24 +0100 Simona Vetter wrote: > On Thu, Jan 30, 2025 at 01:08:56PM +, Florent Tomasin wrote: > > Hi, > > > > This is a patch series covering the support for protected mode execution in > > Mali Panthor CSF kernel driver. > > > > The Mali CSF GPUs come with the supp

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-01-30 Thread Nicolas Dufresne
Le jeudi 30 janvier 2025 à 17:38 +0100, Maxime Ripard a écrit : > Hi Nicolas, > > On Thu, Jan 30, 2025 at 10:59:56AM -0500, Nicolas Dufresne wrote: > > Le jeudi 30 janvier 2025 à 14:46 +0100, Maxime Ripard a écrit : > > > Hi, > > > > > > I started to review it, but it's probably best to discuss i

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-01-30 Thread Maxime Ripard
Hi Nicolas, On Thu, Jan 30, 2025 at 10:59:56AM -0500, Nicolas Dufresne wrote: > Le jeudi 30 janvier 2025 à 14:46 +0100, Maxime Ripard a écrit : > > Hi, > > > > I started to review it, but it's probably best to discuss it here. > > > > On Thu, Jan 30, 2025 at 01:08:56PM +, Florent Tomasin wro

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-01-30 Thread Simona Vetter
On Thu, Jan 30, 2025 at 01:08:56PM +, Florent Tomasin wrote: > Hi, > > This is a patch series covering the support for protected mode execution in > Mali Panthor CSF kernel driver. > > The Mali CSF GPUs come with the support for protected mode execution at the > HW level. This feature require

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-01-30 Thread Nicolas Dufresne
Le jeudi 30 janvier 2025 à 14:46 +0100, Maxime Ripard a écrit : > Hi, > > I started to review it, but it's probably best to discuss it here. > > On Thu, Jan 30, 2025 at 01:08:56PM +, Florent Tomasin wrote: > > Hi, > > > > This is a patch series covering the support for protected mode executi

Re: [RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-01-30 Thread Maxime Ripard
Hi, I started to review it, but it's probably best to discuss it here. On Thu, Jan 30, 2025 at 01:08:56PM +, Florent Tomasin wrote: > Hi, > > This is a patch series covering the support for protected mode execution in > Mali Panthor CSF kernel driver. > > The Mali CSF GPUs come with the sup

[RFC PATCH 0/5] drm/panthor: Protected mode support for Mali CSF GPUs

2025-01-30 Thread Florent Tomasin
Hi, This is a patch series covering the support for protected mode execution in Mali Panthor CSF kernel driver. The Mali CSF GPUs come with the support for protected mode execution at the HW level. This feature requires two main changes in the kernel driver: 1) Configure the GPU with a protected