Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-29 Thread Jessica Zhang
On 6/29/2023 12:29 AM, Pekka Paalanen wrote: On Wed, 28 Jun 2023 09:40:21 -0700 Jessica Zhang wrote: On 6/28/2023 12:34 AM, Pekka Paalanen wrote: On Tue, 27 Jun 2023 15:10:19 -0700 Abhinav Kumar wrote: On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: On 28/06/2023 00:27, Jessica Zhang

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-29 Thread Jessica Zhang
On 6/27/2023 3:10 PM, Abhinav Kumar wrote: On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: On 28/06/2023 00:27, Jessica Zhang wrote: On 6/27/2023 12:58 AM, Pekka Paalanen wrote: On Mon, 26 Jun 2023 16:02:50 -0700 Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri,

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-29 Thread Pekka Paalanen
On Wed, 28 Jun 2023 09:40:21 -0700 Jessica Zhang wrote: > On 6/28/2023 12:34 AM, Pekka Paalanen wrote: > > On Tue, 27 Jun 2023 15:10:19 -0700 > > Abhinav Kumar wrote: > > > >> On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: > >>> On 28/06/2023 00:27, Jessica Zhang wrote: > > > >>>

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-28 Thread Jessica Zhang
On 6/28/2023 12:34 AM, Pekka Paalanen wrote: On Tue, 27 Jun 2023 15:10:19 -0700 Abhinav Kumar wrote: On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: On 28/06/2023 00:27, Jessica Zhang wrote: On 6/27/2023 12:58 AM, Pekka Paalanen wrote: On Mon, 26 Jun 2023 16:02:50 -0700 Jessica Zhang wr

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-28 Thread Pekka Paalanen
On Tue, 27 Jun 2023 15:10:19 -0700 Abhinav Kumar wrote: > On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: > > On 28/06/2023 00:27, Jessica Zhang wrote: > >> > >> > >> On 6/27/2023 12:58 AM, Pekka Paalanen wrote: > >>> On Mon, 26 Jun 2023 16:02:50 -0700 > >>> Jessica Zhang wrote: > >>> >

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-27 Thread Abhinav Kumar
On 6/27/2023 2:59 PM, Dmitry Baryshkov wrote: On 28/06/2023 00:27, Jessica Zhang wrote: On 6/27/2023 12:58 AM, Pekka Paalanen wrote: On Mon, 26 Jun 2023 16:02:50 -0700 Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zha

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-27 Thread Dmitry Baryshkov
On 28/06/2023 00:27, Jessica Zhang wrote: On 6/27/2023 12:58 AM, Pekka Paalanen wrote: On Mon, 26 Jun 2023 16:02:50 -0700 Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FIL

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-27 Thread Jessica Zhang
On 6/27/2023 12:58 AM, Pekka Paalanen wrote: On Mon, 26 Jun 2023 16:02:50 -0700 Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When t

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-27 Thread Pekka Paalanen
On Mon, 26 Jun 2023 16:02:50 -0700 Jessica Zhang wrote: > On 11/7/2022 11:37 AM, Ville Syrjälä wrote: > > On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: > >> Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT > >> properties. When the color fill value is set, and the

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-26 Thread Dmitry Baryshkov
On Tue, 27 Jun 2023 at 03:45, Jessica Zhang wrote: > > > > On 6/26/2023 5:06 PM, Dmitry Baryshkov wrote: > > On 27/06/2023 02:02, Jessica Zhang wrote: > >> > >> > >> On 11/7/2022 11:37 AM, Ville Syrjälä wrote: > >>> On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: > Introduce an

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-26 Thread Jessica Zhang
On 6/26/2023 5:06 PM, Dmitry Baryshkov wrote: On 27/06/2023 02:02, Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color fill

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-26 Thread Dmitry Baryshkov
On 27/06/2023 02:02, Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color fill value is set, and the framebuffer is set to NULL,

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-26 Thread Jessica Zhang
On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color fill value is set, and the framebuffer is set to NULL, memory fetch will be disabled. Thinking

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2022-11-22 Thread Jessica Zhang
On 11/8/2022 12:52 AM, Ville Syrjälä wrote: On Mon, Nov 07, 2022 at 07:34:43PM -0800, Rob Clark wrote: On Mon, Nov 7, 2022 at 4:22 PM Jessica Zhang wrote: On 11/7/2022 2:09 PM, Rob Clark wrote: On Mon, Nov 7, 2022 at 1:32 PM Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2022-11-08 Thread Ville Syrjälä
On Mon, Nov 07, 2022 at 07:34:43PM -0800, Rob Clark wrote: > On Mon, Nov 7, 2022 at 4:22 PM Jessica Zhang > wrote: > > > > > > > > On 11/7/2022 2:09 PM, Rob Clark wrote: > > > On Mon, Nov 7, 2022 at 1:32 PM Jessica Zhang > > > wrote: > > >> > > >> > > >> > > >> On 11/7/2022 11:37 AM, Ville Syrj

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2022-11-07 Thread Rob Clark
On Mon, Nov 7, 2022 at 4:22 PM Jessica Zhang wrote: > > > > On 11/7/2022 2:09 PM, Rob Clark wrote: > > On Mon, Nov 7, 2022 at 1:32 PM Jessica Zhang > > wrote: > >> > >> > >> > >> On 11/7/2022 11:37 AM, Ville Syrjälä wrote: > >>> On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: > >>

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2022-11-07 Thread Jessica Zhang
On 11/7/2022 2:09 PM, Rob Clark wrote: On Mon, Nov 7, 2022 at 1:32 PM Jessica Zhang wrote: On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2022-11-07 Thread Laurent Pinchart
On Mon, Nov 07, 2022 at 09:37:08PM +0200, Ville Syrjälä wrote: > On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: > > Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT > > properties. When the color fill value is set, and the framebuffer is set > > to NULL, memory fetch w

Re: [Freedreno] [RFC PATCH 0/3] Support for Solid Fill Planes

2022-11-07 Thread Rob Clark
On Mon, Nov 7, 2022 at 1:32 PM Jessica Zhang wrote: > > > > On 11/7/2022 11:37 AM, Ville Syrjälä wrote: > > On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: > >> Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT > >> properties. When the color fill value is set, and the

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2022-11-07 Thread Jessica Zhang
On 11/7/2022 11:37 AM, Ville Syrjälä wrote: On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color fill value is set, and the framebuffer is set to NULL, memory fetch will be disabled. Thinking

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2022-11-07 Thread Ville Syrjälä
On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: > Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT > properties. When the color fill value is set, and the framebuffer is set > to NULL, memory fetch will be disabled. Thinking a bit more universally I wonder if there sho

[RFC PATCH 0/3] Support for Solid Fill Planes

2022-10-28 Thread Jessica Zhang
Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color fill value is set, and the framebuffer is set to NULL, memory fetch will be disabled. In addition, loosen the NULL FB checks within the atomic commit callstack to allow a NULL FB when color_fill is nonzero an