[RFC PATCH] drm: Add plane event

2012-04-19 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 09:19:42PM +0300, Ville Syrj?l? wrote: > On Wed, Apr 18, 2012 at 07:06:10PM +0300, Ville Syrj?l? wrote: > > On Wed, Apr 18, 2012 at 05:27:57PM +0200, Daniel Vetter wrote: > > > Also, I'm toying around with ideas to split up the big modeset lock such > > > that operations tha

[RFC PATCH] drm: Add plane event

2012-04-19 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 09:24:58PM -0400, Kristian H?gsberg wrote: > One thing that's not clear to me is how we would enable a sprite > without going through the atomic modeset again. If the atomic modeset > is all about calculating bandwidth requirements etc, then enabling a > sprite will affect

Re: [RFC PATCH] drm: Add plane event

2012-04-19 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 09:19:42PM +0300, Ville Syrjälä wrote: > On Wed, Apr 18, 2012 at 07:06:10PM +0300, Ville Syrjälä wrote: > > On Wed, Apr 18, 2012 at 05:27:57PM +0200, Daniel Vetter wrote: > > > Also, I'm toying around with ideas to split up the big modeset lock such > > > that operations tha

Re: [RFC PATCH] drm: Add plane event

2012-04-19 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 09:24:58PM -0400, Kristian Høgsberg wrote: > One thing that's not clear to me is how we would enable a sprite > without going through the atomic modeset again. If the atomic modeset > is all about calculating bandwidth requirements etc, then enabling a > sprite will affect

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Kristian Høgsberg
On Wed, Apr 18, 2012 at 10:36 AM, Daniel Vetter wrote: > On Wed, Apr 18, 2012 at 05:26:07PM +0300, Ville Syrjälä wrote: >> On Wed, Apr 18, 2012 at 04:04:56PM +0200, Marcus Lorentzon wrote: >> > On 04/18/2012 02:25 PM, Rob Clark wrote: >> > > On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim >> > >

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Kristian Høgsberg
On Wed, Apr 18, 2012 at 10:36 AM, Daniel Vetter wrote: > On Wed, Apr 18, 2012 at 05:26:07PM +0300, Ville Syrj?l? wrote: >> On Wed, Apr 18, 2012 at 04:04:56PM +0200, Marcus Lorentzon wrote: >> > On 04/18/2012 02:25 PM, Rob Clark wrote: >> > > On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim> > > sam

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Ville Syrjälä
On Wed, Apr 18, 2012 at 07:06:10PM +0300, Ville Syrj?l? wrote: > On Wed, Apr 18, 2012 at 05:27:57PM +0200, Daniel Vetter wrote: > > Also, I'm toying around with ideas to split up the big modeset lock such > > that operations that only touch the crtc (like pageflip, plane changes and > > cursor chan

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 05:55:15PM +0200, Marcus Lorentzon wrote: > On 04/18/2012 05:27 PM, Daniel Vetter wrote: > >On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: > >>On 04/18/2012 04:36 PM, Daniel Vetter wrote: > >>>Last time around I've discussed with people we've ended up with

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Joonyoung Shim
On 04/18/2012 05:46 PM, Daniel Vetter wrote: > On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: >> DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is >> for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to >> provide the event such as DRM_MODE_PAGE_FL

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Ville Syrjälä
On Wed, Apr 18, 2012 at 05:27:57PM +0200, Daniel Vetter wrote: > On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: > > On 04/18/2012 04:36 PM, Daniel Vetter wrote: > > >Last time around I've discussed with people we've ended up with 2 new > > >ioctls: > > > > > >- atomic modeset, to

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Luc Verhaegen
On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: > DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is > for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to > provide the event such as DRM_MODE_PAGE_FLIP_EVENT. The setplane ioctl > can change the fram

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 06:06 PM, Ville Syrj?l? wrote: >> > If you smash everything into one ioctl, I imagine you have plenty of fun >> > implementing all this. Which is why I prefer to split this up. > I don't think there's that much differnce. You build up the full device > state, check it, and when you'

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 05:43 PM, Luc Verhaegen wrote: > This means that there should be (at least) three separate actions: > * page flipping: buffers -> planes at next vblank, for a list of > buffer(s) and plane tuples. > * setplanes: colour format, position, scaling, ordering, rotation, color > key, crtc

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 05:27 PM, Daniel Vetter wrote: > On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: >> On 04/18/2012 04:36 PM, Daniel Vetter wrote: >>> Last time around I've discussed with people we've ended up with 2 new >>> ioctls: >>> >>> - atomic modeset, to configure the output st

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Luc Verhaegen
On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: > On 04/18/2012 04:36 PM, Daniel Vetter wrote: >> Last time around I've discussed with people we've ended up with 2 new >> ioctls: >> >> - atomic modeset, to configure the output state on more than one crtc at >>the same time. Th

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: > On 04/18/2012 04:36 PM, Daniel Vetter wrote: > >Last time around I've discussed with people we've ended up with 2 new > >ioctls: > > > >- atomic modeset, to configure the output state on more than one crtc at > > the same time. T

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Ville Syrjälä
On Wed, Apr 18, 2012 at 04:04:56PM +0200, Marcus Lorentzon wrote: > On 04/18/2012 02:25 PM, Rob Clark wrote: > > On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim > > wrote: > >> On 04/18/2012 05:46 PM, Daniel Vetter wrote: > >>> On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: > >>>

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 04:36 PM, Daniel Vetter wrote: > Last time around I've discussed with people we've ended up with 2 new > ioctls: > > - atomic modeset, to configure the output state on more than one crtc at >the same time. This is useful to get pll assignement, memory bandwidth >constrains and

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 04:26 PM, Ville Syrj?l? wrote: > On Wed, Apr 18, 2012 at 04:04:56PM +0200, Marcus Lorentzon wrote: >> On 04/18/2012 02:25 PM, Rob Clark wrote: >>> On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim >>> wrote: On 04/18/2012 05:46 PM, Daniel Vetter wrote: > On Wed, Apr 18, 2012

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 05:26:07PM +0300, Ville Syrj?l? wrote: > On Wed, Apr 18, 2012 at 04:04:56PM +0200, Marcus Lorentzon wrote: > > On 04/18/2012 02:25 PM, Rob Clark wrote: > > > On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim > > samsung.com> wrote: > > >> On 04/18/2012 05:46 PM, Daniel Vetter

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 02:25 PM, Rob Clark wrote: > On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim > wrote: >> On 04/18/2012 05:46 PM, Daniel Vetter wrote: >>> On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is f

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Joonyoung Shim
DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to provide the event such as DRM_MODE_PAGE_FLIP_EVENT. The setplane ioctl can change the framebuffer of plane but user can't know completion of changing the framebuf

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 05:55:15PM +0200, Marcus Lorentzon wrote: > On 04/18/2012 05:27 PM, Daniel Vetter wrote: > >On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: > >>On 04/18/2012 04:36 PM, Daniel Vetter wrote: > >>>Last time around I've discussed with people we've ended up with

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Ville Syrjälä
On Wed, Apr 18, 2012 at 07:06:10PM +0300, Ville Syrjälä wrote: > On Wed, Apr 18, 2012 at 05:27:57PM +0200, Daniel Vetter wrote: > > Also, I'm toying around with ideas to split up the big modeset lock such > > that operations that only touch the crtc (like pageflip, plane changes and > > cursor chan

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: > DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is > for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to > provide the event such as DRM_MODE_PAGE_FLIP_EVENT. The setplane ioctl > can change the fram

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Luc Verhaegen
On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: > DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is > for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to > provide the event such as DRM_MODE_PAGE_FLIP_EVENT. The setplane ioctl > can change the fram

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 06:06 PM, Ville Syrjälä wrote: > If you smash everything into one ioctl, I imagine you have plenty of fun > implementing all this. Which is why I prefer to split this up. I don't think there's that much differnce. You build up the full device state, check it, and when you're read

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Ville Syrjälä
On Wed, Apr 18, 2012 at 05:27:57PM +0200, Daniel Vetter wrote: > On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: > > On 04/18/2012 04:36 PM, Daniel Vetter wrote: > > >Last time around I've discussed with people we've ended up with 2 new > > >ioctls: > > > > > >- atomic modeset, to

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Jesse Barnes
On Wed, 18 Apr 2012 17:55:15 +0200 Marcus Lorentzon wrote: > The async vs sync makes sense as reason for splitting them. My problem > lies somewhere in between sync modeset and async flip - async > crtc/plane/fbs modeset. > In Wayland and Android HW composer I need to asynchronously flip and do

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Jesse Barnes
On Wed, 18 Apr 2012 17:55:15 +0200 Marcus Lorentzon wrote: > The async vs sync makes sense as reason for splitting them. My problem > lies somewhere in between sync modeset and async flip - async > crtc/plane/fbs modeset. > In Wayland and Android HW composer I need to asynchronously flip and do

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 05:43 PM, Luc Verhaegen wrote: This means that there should be (at least) three separate actions: * page flipping: buffers -> planes at next vblank, for a list of buffer(s) and plane tuples. * setplanes: colour format, position, scaling, ordering, rotation, color key, crtc adheranc

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Jesse Barnes
On Wed, 18 Apr 2012 16:58:36 +0200 Marcus Lorentzon wrote: > On 04/18/2012 04:26 PM, Ville Syrjälä wrote: > Yes, from previous emails I have seen that we are quite aligned on the > single-atomic-modeset-with-properties version. > > Do you have any actual proposal for this? Like the API at leas

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Jesse Barnes
On Wed, 18 Apr 2012 16:58:36 +0200 Marcus Lorentzon wrote: > On 04/18/2012 04:26 PM, Ville Syrj?l? wrote: > Yes, from previous emails I have seen that we are quite aligned on the > single-atomic-modeset-with-properties version. > > Do you have any actual proposal for this? Like the API at leas

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 05:27 PM, Daniel Vetter wrote: On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: On 04/18/2012 04:36 PM, Daniel Vetter wrote: Last time around I've discussed with people we've ended up with 2 new ioctls: - atomic modeset, to configure the output state on more than

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Luc Verhaegen
On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: > On 04/18/2012 04:36 PM, Daniel Vetter wrote: >> Last time around I've discussed with people we've ended up with 2 new >> ioctls: >> >> - atomic modeset, to configure the output state on more than one crtc at >>the same time. Th

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 05:10:47PM +0200, Marcus Lorentzon wrote: > On 04/18/2012 04:36 PM, Daniel Vetter wrote: > >Last time around I've discussed with people we've ended up with 2 new > >ioctls: > > > >- atomic modeset, to configure the output state on more than one crtc at > > the same time. T

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 04:36 PM, Daniel Vetter wrote: Last time around I've discussed with people we've ended up with 2 new ioctls: - atomic modeset, to configure the output state on more than one crtc at the same time. This is useful to get pll assignement, memory bandwidth constrains and similar

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 04:26 PM, Ville Syrjälä wrote: On Wed, Apr 18, 2012 at 04:04:56PM +0200, Marcus Lorentzon wrote: On 04/18/2012 02:25 PM, Rob Clark wrote: On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim wrote: On 04/18/2012 05:46 PM, Daniel Vetter wrote: On Wed, Apr 18, 2012 at 01:31:59PM +09

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 05:26:07PM +0300, Ville Syrjälä wrote: > On Wed, Apr 18, 2012 at 04:04:56PM +0200, Marcus Lorentzon wrote: > > On 04/18/2012 02:25 PM, Rob Clark wrote: > > > On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim > > > wrote: > > >> On 04/18/2012 05:46 PM, Daniel Vetter wrote: >

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Ville Syrjälä
On Wed, Apr 18, 2012 at 04:04:56PM +0200, Marcus Lorentzon wrote: > On 04/18/2012 02:25 PM, Rob Clark wrote: > > On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim > > wrote: > >> On 04/18/2012 05:46 PM, Daniel Vetter wrote: > >>> On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: > >>>

[RFC PATCH] drm: Add plane event

2012-04-18 Thread Rob Clark
On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim wrote: > > On 04/18/2012 05:46 PM, Daniel Vetter wrote: >> >> On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: >>> >>> DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is >>> for a plane. The setplane ioctl (DRM_IOCT

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Marcus Lorentzon
On 04/18/2012 02:25 PM, Rob Clark wrote: On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim wrote: On 04/18/2012 05:46 PM, Daniel Vetter wrote: On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is for a plane. The s

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Rob Clark
On Wed, Apr 18, 2012 at 5:11 AM, Joonyoung Shim wrote: > > On 04/18/2012 05:46 PM, Daniel Vetter wrote: >> >> On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: >>> >>> DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is >>> for a plane. The setplane ioctl (DRM_IOCTL

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Joonyoung Shim
On 04/18/2012 05:46 PM, Daniel Vetter wrote: On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to provide the event such as DRM_MODE_PAGE_FLIP_EVENT

Re: [RFC PATCH] drm: Add plane event

2012-04-18 Thread Daniel Vetter
On Wed, Apr 18, 2012 at 01:31:59PM +0900, Joonyoung Shim wrote: > DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is > for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to > provide the event such as DRM_MODE_PAGE_FLIP_EVENT. The setplane ioctl > can change the fram

[RFC PATCH] drm: Add plane event

2012-04-17 Thread Joonyoung Shim
DRM_MODE_PLANE_EVENT is similar to DRM_MODE_PAGE_FLIP_EVENT but it is for a plane. The setplane ioctl (DRM_IOCTL_MODE_SETPLANE) needs to provide the event such as DRM_MODE_PAGE_FLIP_EVENT. The setplane ioctl can change the framebuffer of plane but user can't know completion of changing the framebuf