Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-29 Thread Daniel Vetter
On Mon, Oct 29, 2018 at 10:10:56AM +0100, Boris Brezillon wrote: > On Mon, 29 Oct 2018 10:03:01 +0100 > Daniel Vetter wrote: > > On Mon, Oct 29, 2018 at 09:41:36AM +0100, Boris Brezillon wrote: > > > On Mon, 29 Oct 2018 09:06:40 +0100 > > > > The other upshot of a counter is that there's no proble

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-29 Thread Boris Brezillon
On Mon, 29 Oct 2018 10:03:01 +0100 Daniel Vetter wrote: > On Mon, Oct 29, 2018 at 09:41:36AM +0100, Boris Brezillon wrote: > > On Mon, 29 Oct 2018 09:06:40 +0100 > > Daniel Vetter wrote: > > > > > On Fri, Oct 26, 2018 at 06:10:03PM +0300, Ville Syrjälä wrote: > > > > On Fri, Oct 26, 2018 at

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-29 Thread Daniel Vetter
On Mon, Oct 29, 2018 at 09:41:36AM +0100, Boris Brezillon wrote: > On Mon, 29 Oct 2018 09:06:40 +0100 > Daniel Vetter wrote: > > > On Fri, Oct 26, 2018 at 06:10:03PM +0300, Ville Syrjälä wrote: > > > On Fri, Oct 26, 2018 at 04:52:33PM +0200, Boris Brezillon wrote: > > > > On Fri, 26 Oct 2018 16

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-29 Thread Boris Brezillon
On Mon, 29 Oct 2018 09:06:40 +0100 Daniel Vetter wrote: > On Fri, Oct 26, 2018 at 06:10:03PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 26, 2018 at 04:52:33PM +0200, Boris Brezillon wrote: > > > On Fri, 26 Oct 2018 16:26:03 +0200 > > > Daniel Vetter wrote: > > > > > > > On Fri, Oct 26, 201

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-29 Thread Daniel Vetter
On Fri, Oct 26, 2018 at 06:10:03PM +0300, Ville Syrjälä wrote: > On Fri, Oct 26, 2018 at 04:52:33PM +0200, Boris Brezillon wrote: > > On Fri, 26 Oct 2018 16:26:03 +0200 > > Daniel Vetter wrote: > > > > > On Fri, Oct 26, 2018 at 3:57 PM Boris Brezillon > > > wrote: > > > > > > > > On Fri, 26 Oct

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-26 Thread Ville Syrjälä
On Fri, Oct 26, 2018 at 04:52:33PM +0200, Boris Brezillon wrote: > On Fri, 26 Oct 2018 16:26:03 +0200 > Daniel Vetter wrote: > > > On Fri, Oct 26, 2018 at 3:57 PM Boris Brezillon > > wrote: > > > > > > On Fri, 26 Oct 2018 15:30:26 +0200 > > > Daniel Vetter wrote: > > > > > > > On Thu, Oct 25,

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-26 Thread Boris Brezillon
On Fri, 26 Oct 2018 16:26:03 +0200 Daniel Vetter wrote: > On Fri, Oct 26, 2018 at 3:57 PM Boris Brezillon > wrote: > > > > On Fri, 26 Oct 2018 15:30:26 +0200 > > Daniel Vetter wrote: > > > > > On Thu, Oct 25, 2018 at 11:41:14AM +0200, Boris Brezillon wrote: > > > > On Thu, 25 Oct 2018 11:33

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-26 Thread Daniel Vetter
On Fri, Oct 26, 2018 at 3:57 PM Boris Brezillon wrote: > > On Fri, 26 Oct 2018 15:30:26 +0200 > Daniel Vetter wrote: > > > On Thu, Oct 25, 2018 at 11:41:14AM +0200, Boris Brezillon wrote: > > > On Thu, 25 Oct 2018 11:33:14 +0200 > > > Daniel Vetter wrote: > > > > > > > On Thu, Oct 25, 2018 at 10

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-26 Thread Boris Brezillon
On Fri, 26 Oct 2018 15:30:26 +0200 Daniel Vetter wrote: > On Thu, Oct 25, 2018 at 11:41:14AM +0200, Boris Brezillon wrote: > > On Thu, 25 Oct 2018 11:33:14 +0200 > > Daniel Vetter wrote: > > > > > On Thu, Oct 25, 2018 at 10:09:31AM +0200, Boris Brezillon wrote: > > > > On Tue, 23 Oct 2018 1

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-26 Thread Daniel Vetter
On Thu, Oct 25, 2018 at 11:41:14AM +0200, Boris Brezillon wrote: > On Thu, 25 Oct 2018 11:33:14 +0200 > Daniel Vetter wrote: > > > On Thu, Oct 25, 2018 at 10:09:31AM +0200, Boris Brezillon wrote: > > > On Tue, 23 Oct 2018 15:44:43 +0200 > > > Daniel Vetter wrote: > > > > > > > On Tue, Oct 23,

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-25 Thread Boris Brezillon
On Thu, 25 Oct 2018 11:33:14 +0200 Daniel Vetter wrote: > On Thu, Oct 25, 2018 at 10:09:31AM +0200, Boris Brezillon wrote: > > On Tue, 23 Oct 2018 15:44:43 +0200 > > Daniel Vetter wrote: > > > > > On Tue, Oct 23, 2018 at 09:55:08AM +0200, Boris Brezillon wrote: > > > > Hi Daniel, > > > > >

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-25 Thread Daniel Vetter
On Thu, Oct 25, 2018 at 10:09:31AM +0200, Boris Brezillon wrote: > On Tue, 23 Oct 2018 15:44:43 +0200 > Daniel Vetter wrote: > > > On Tue, Oct 23, 2018 at 09:55:08AM +0200, Boris Brezillon wrote: > > > Hi Daniel, > > > > > > On Tue, 16 Oct 2018 14:57:43 +0200 > > > Daniel Vetter wrote: > > >

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-25 Thread Boris Brezillon
On Tue, 23 Oct 2018 15:44:43 +0200 Daniel Vetter wrote: > On Tue, Oct 23, 2018 at 09:55:08AM +0200, Boris Brezillon wrote: > > Hi Daniel, > > > > On Tue, 16 Oct 2018 14:57:43 +0200 > > Daniel Vetter wrote: > > > > > On Tue, Oct 16, 2018 at 11:40:45AM +0200, Boris Brezillon wrote: > > > > T

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-23 Thread Daniel Vetter
On Tue, Oct 23, 2018 at 09:55:08AM +0200, Boris Brezillon wrote: > Hi Daniel, > > On Tue, 16 Oct 2018 14:57:43 +0200 > Daniel Vetter wrote: > > > On Tue, Oct 16, 2018 at 11:40:45AM +0200, Boris Brezillon wrote: > > > The HVS block is supposed to fill the pixelvalve FIFOs fast enough to > > > mee

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-23 Thread Boris Brezillon
Hi Daniel, On Tue, 16 Oct 2018 14:57:43 +0200 Daniel Vetter wrote: > On Tue, Oct 16, 2018 at 11:40:45AM +0200, Boris Brezillon wrote: > > The HVS block is supposed to fill the pixelvalve FIFOs fast enough to > > meet the requested framerate. The problem is, the HVS and memory bus > > bandwidths

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-17 Thread Boris Brezillon
+Rob On Tue, 16 Oct 2018 18:41:51 +0200 Daniel Vetter wrote: > On Tue, Oct 16, 2018 at 04:28:09PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 03:12:54PM +0200, Daniel Vetter wrote: > > > On Tue, Oct 16, 2018 at 3:10 PM Boris Brezillon > > > wrote: > > > > > > > > Hi Daniel, > >

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 7:39 PM Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 06:41:51PM +0200, Daniel Vetter wrote: > > On Tue, Oct 16, 2018 at 04:28:09PM +0300, Ville Syrjälä wrote: > > > On Tue, Oct 16, 2018 at 03:12:54PM +0200, Daniel Vetter wrote: > > > > On Tue, Oct 16, 2018 at 3:10 PM Bo

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 06:41:51PM +0200, Daniel Vetter wrote: > On Tue, Oct 16, 2018 at 04:28:09PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 16, 2018 at 03:12:54PM +0200, Daniel Vetter wrote: > > > On Tue, Oct 16, 2018 at 3:10 PM Boris Brezillon > > > wrote: > > > > > > > > Hi Daniel, > > > > >

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 04:28:09PM +0300, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 03:12:54PM +0200, Daniel Vetter wrote: > > On Tue, Oct 16, 2018 at 3:10 PM Boris Brezillon > > wrote: > > > > > > Hi Daniel, > > > > > > On Tue, 16 Oct 2018 14:57:43 +0200 > > > Daniel Vetter wrote: > > > > >

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 03:12:54PM +0200, Daniel Vetter wrote: > On Tue, Oct 16, 2018 at 3:10 PM Boris Brezillon > wrote: > > > > Hi Daniel, > > > > On Tue, 16 Oct 2018 14:57:43 +0200 > > Daniel Vetter wrote: > > > > > On Tue, Oct 16, 2018 at 11:40:45AM +0200, Boris Brezillon wrote: > > > > The H

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 3:10 PM Boris Brezillon wrote: > > Hi Daniel, > > On Tue, 16 Oct 2018 14:57:43 +0200 > Daniel Vetter wrote: > > > On Tue, Oct 16, 2018 at 11:40:45AM +0200, Boris Brezillon wrote: > > > The HVS block is supposed to fill the pixelvalve FIFOs fast enough to > > > meet the req

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Boris Brezillon
Hi Daniel, On Tue, 16 Oct 2018 14:57:43 +0200 Daniel Vetter wrote: > On Tue, Oct 16, 2018 at 11:40:45AM +0200, Boris Brezillon wrote: > > The HVS block is supposed to fill the pixelvalve FIFOs fast enough to > > meet the requested framerate. The problem is, the HVS and memory bus > > bandwidths

Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 11:40:45AM +0200, Boris Brezillon wrote: > The HVS block is supposed to fill the pixelvalve FIFOs fast enough to > meet the requested framerate. The problem is, the HVS and memory bus > bandwidths are limited, and if we don't take these limitations into > account we might en

[RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors

2018-10-16 Thread Boris Brezillon
The HVS block is supposed to fill the pixelvalve FIFOs fast enough to meet the requested framerate. The problem is, the HVS and memory bus bandwidths are limited, and if we don't take these limitations into account we might end up with HVS underflow errors. This patch is trying to model the per-pl