Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 05:49:50PM +0200, Thomas Hellström wrote: > On Mon, 2021-04-12 at 17:43 +0200, Daniel Vetter wrote: > > On Mon, Apr 12, 2021 at 04:21:37PM +0200, Christian König wrote: > > > > > > > > > Am 12.04.21 um 16:16 schrieb Thomas Hellström: > > > > Hi, Christian, > > > > > > > >

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
On Mon, 2021-04-12 at 17:43 +0200, Daniel Vetter wrote: > On Mon, Apr 12, 2021 at 04:21:37PM +0200, Christian König wrote: > > > > > > Am 12.04.21 um 16:16 schrieb Thomas Hellström: > > > Hi, Christian, > > > > > > On 4/12/21 4:01 PM, Christian König wrote: > > > > Hi Thomas, > > > > > > > > we

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 04:21:37PM +0200, Christian König wrote: > > > Am 12.04.21 um 16:16 schrieb Thomas Hellström: > > Hi, Christian, > > > > On 4/12/21 4:01 PM, Christian König wrote: > > > Hi Thomas, > > > > > > well in general a good idea, but I'm working on a different plan for > > > a w

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Christian König
Am 12.04.21 um 16:40 schrieb Thomas Hellström: On 4/12/21 4:21 PM, Christian König wrote: Am 12.04.21 um 16:16 schrieb Thomas Hellström: Hi, Christian, On 4/12/21 4:01 PM, Christian König wrote: Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now.

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
On 4/12/21 4:21 PM, Christian König wrote: Am 12.04.21 um 16:16 schrieb Thomas Hellström: Hi, Christian, On 4/12/21 4:01 PM, Christian König wrote: Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the res

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Christian König
Am 12.04.21 um 16:16 schrieb Thomas Hellström: Hi, Christian, On 4/12/21 4:01 PM, Christian König wrote: Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the resource object is kept on a double linked lru

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
Hi, Christian, On 4/12/21 4:01 PM, Christian König wrote: Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the resource object is kept on a double linked lru list. The resource objects then have a pointer t

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Christian König
Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the resource object is kept on a double linked lru list. The resource objects then have a pointer to either the BO or a fence object. When it is a fence objec

[RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
This RFC needs some decent testing on a driver with bos that share reservation objects, and of course a check for whether I missed something obvious. The locking around delayed destroy is rather complex due to the fact that we want to individualize dma_resv pointers before putting the object on th