Re: [RFC 09/17] drm/amdgpu: use dma-fence annotations in cs_submit()

2020-05-13 Thread Daniel Vetter
On Wed, May 13, 2020 at 9:02 AM Christian König wrote: > > Am 12.05.20 um 10:59 schrieb Daniel Vetter: > > This is a bit tricky, since ->notifier_lock is held while calling > > dma_fence_wait we must ensure that also the read side (i.e. > > dma_fence_begin_signalling) is on the same side. If we mi

Re: [RFC 09/17] drm/amdgpu: use dma-fence annotations in cs_submit()

2020-05-13 Thread Christian König
Am 12.05.20 um 10:59 schrieb Daniel Vetter: This is a bit tricky, since ->notifier_lock is held while calling dma_fence_wait we must ensure that also the read side (i.e. dma_fence_begin_signalling) is on the same side. If we mix this up lockdep complaints, and that's again why we want to have the

[RFC 09/17] drm/amdgpu: use dma-fence annotations in cs_submit()

2020-05-12 Thread Daniel Vetter
This is a bit tricky, since ->notifier_lock is held while calling dma_fence_wait we must ensure that also the read side (i.e. dma_fence_begin_signalling) is on the same side. If we mix this up lockdep complaints, and that's again why we want to have these annotations. A nice side effect of this is