Re: [RFC] swap event handling fixes

2011-05-02 Thread Jesse Barnes
On Sat, 30 Apr 2011 01:10:27 +0200 Mario Kleiner wrote: > > On Apr 29, 2011, at 11:37 PM, Jesse Barnes wrote: > > > On Thu, 28 Apr 2011 13:27:18 -0700 > > Jesse Barnes wrote: > > > >> I obviously failed to count the swap event structure size after > >> adding > >> and removing fields a few t

[RFC] swap event handling fixes

2011-05-02 Thread Jesse Barnes
On Sat, 30 Apr 2011 01:10:27 +0200 Mario Kleiner wrote: > > On Apr 29, 2011, at 11:37 PM, Jesse Barnes wrote: > > > On Thu, 28 Apr 2011 13:27:18 -0700 > > Jesse Barnes wrote: > > > >> I obviously failed to count the swap event structure size after > >> adding > >> and removing fields a few t

[RFC] swap event handling fixes

2011-04-30 Thread Mario Kleiner
On Apr 29, 2011, at 11:37 PM, Jesse Barnes wrote: > On Thu, 28 Apr 2011 13:27:18 -0700 > Jesse Barnes wrote: > >> I obviously failed to count the swap event structure size after >> adding >> and removing fields a few times, and didn't even account for >> padding. The >> end result is that c

Re: [RFC] swap event handling fixes

2011-04-29 Thread Mario Kleiner
On Apr 29, 2011, at 11:37 PM, Jesse Barnes wrote: On Thu, 28 Apr 2011 13:27:18 -0700 Jesse Barnes wrote: I obviously failed to count the swap event structure size after adding and removing fields a few times, and didn't even account for padding. The end result is that clients today won't

Re: [RFC] swap event handling fixes

2011-04-29 Thread Jesse Barnes
On Thu, 28 Apr 2011 13:27:18 -0700 Jesse Barnes wrote: > I obviously failed to count the swap event structure size after adding > and removing fields a few times, and didn't even account for padding. The > end result is that clients today won't receive the sbc_lo field at all, > and so will like

[RFC] swap event handling fixes

2011-04-29 Thread Jesse Barnes
On Thu, 28 Apr 2011 13:27:18 -0700 Jesse Barnes wrote: > I obviously failed to count the swap event structure size after adding > and removing fields a few times, and didn't even account for padding. The > end result is that clients today won't receive the sbc_lo field at all, > and so will like

[RFC] swap event handling fixes

2011-04-28 Thread Jesse Barnes
I obviously failed to count the swap event structure size after adding and removing fields a few times, and didn't even account for padding. The end result is that clients today won't receive the sbc_lo field at all, and so will likely stuff junk into that field on the client side (or zero at best

[RFC] swap event handling fixes

2011-04-28 Thread Jesse Barnes
I obviously failed to count the swap event structure size after adding and removing fields a few times, and didn't even account for padding. The end result is that clients today won't receive the sbc_lo field at all, and so will likely stuff junk into that field on the client side (or zero at best