[RFC] drm/i915: Use generic HDMI infoframe helpers

2012-12-11 Thread Daniel Vetter
On Fri, Dec 7, 2012 at 4:32 PM, Daniel Vetter wrote: >> TODO: >> - The SDVO part is totally untested. I am not sure if the buffer >> size on the SDVO code must be a multiple of 4. Forgotten to mention: SDVO actually needs alignment to blocks of 8, but intel_sdvo_write_infoframe already take

[RFC] drm/i915: Use generic HDMI infoframe helpers

2012-12-11 Thread Thierry Reding
On Fri, Dec 07, 2012 at 01:11:29PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. > > This patch is based on the initial patch by Thierry Reding, but with a > different approach. > > TOD

Re: [RFC] drm/i915: Use generic HDMI infoframe helpers

2012-12-11 Thread Daniel Vetter
On Fri, Dec 7, 2012 at 4:32 PM, Daniel Vetter wrote: >> TODO: >> - The SDVO part is totally untested. I am not sure if the buffer >> size on the SDVO code must be a multiple of 4. Forgotten to mention: SDVO actually needs alignment to blocks of 8, but intel_sdvo_write_infoframe already take

Re: [RFC] drm/i915: Use generic HDMI infoframe helpers

2012-12-11 Thread Thierry Reding
On Fri, Dec 07, 2012 at 01:11:29PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. > > This patch is based on the initial patch by Thierry Reding, but with a > different approach. > > TOD

[RFC] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Daniel Vetter
Hi Paulo, On Fri, Dec 7, 2012 at 4:11 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. > > This patch is based on the initial patch by Thierry Reding, but with a > different approach. > > TODO

[RFC] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Paulo Zanoni
From: Paulo Zanoni Use the generic HDMI infoframe helpers to get rid of the duplicate implementation in the i915 driver. This patch is based on the initial patch by Thierry Reding, but with a different approach. TODO: - The SDVO part is totally untested. I am not sure if the buffer size o

Re: [RFC] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Daniel Vetter
Hi Paulo, On Fri, Dec 7, 2012 at 4:11 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. > > This patch is based on the initial patch by Thierry Reding, but with a > different approach. > > TODO

[RFC] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Paulo Zanoni
From: Paulo Zanoni Use the generic HDMI infoframe helpers to get rid of the duplicate implementation in the i915 driver. This patch is based on the initial patch by Thierry Reding, but with a different approach. TODO: - The SDVO part is totally untested. I am not sure if the buffer size o