Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-28 Thread Lucas De Marchi
On Fri, Mar 25, 2022 at 02:09:33PM +0200, Jani Nikula wrote: On Fri, 25 Mar 2022, Tvrtko Ursulin wrote: On 24/03/2022 18:57, Jani Nikula wrote: On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: On 24/03/2022 11:57, Jani Nikula wrote: On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: On 24/03/2022 09:31

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-25 Thread Jani Nikula
On Fri, 25 Mar 2022, Tvrtko Ursulin wrote: > On 24/03/2022 18:57, Jani Nikula wrote: >> On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: >>> On 24/03/2022 11:57, Jani Nikula wrote: On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: > On 24/03/2022 09:31, Jani Nikula wrote: >> On Tue, 22 Mar 2022,

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-25 Thread Tvrtko Ursulin
On 24/03/2022 18:57, Jani Nikula wrote: On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: On 24/03/2022 11:57, Jani Nikula wrote: On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: On 24/03/2022 09:31, Jani Nikula wrote: On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: From: Tvrtko Ursulin ... Signed-off

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Jani Nikula
On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: > On 24/03/2022 11:57, Jani Nikula wrote: >> On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: >>> On 24/03/2022 09:31, Jani Nikula wrote: On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > ... > > Signed-off-by: Tv

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Tvrtko Ursulin
On 24/03/2022 11:57, Jani Nikula wrote: On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: On 24/03/2022 09:31, Jani Nikula wrote: On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: From: Tvrtko Ursulin ... Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula Cc: Lucas De Marchi --- Typed up how I see it -

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Jani Nikula
On Thu, 24 Mar 2022, Tvrtko Ursulin wrote: > On 24/03/2022 09:31, Jani Nikula wrote: >> On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: >>> From: Tvrtko Ursulin >>> >>> ... >>> >>> Signed-off-by: Tvrtko Ursulin >>> Cc: Jani Nikula >>> Cc: Lucas De Marchi >>> --- >>> Typed up how I see it - bash aw

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Tvrtko Ursulin
On 24/03/2022 09:31, Jani Nikula wrote: On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: From: Tvrtko Ursulin ... Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula Cc: Lucas De Marchi --- Typed up how I see it - bash away. So is intel_vtd_active() so performance critical that it needs to be inl

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Jani Nikula
On Thu, 24 Mar 2022, Jani Nikula wrote: > On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> ... >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Jani Nikula >> Cc: Lucas De Marchi >> --- >> Typed up how I see it - bash away. > > So is intel_vtd_active() so performance critica

Re: [RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-24 Thread Jani Nikula
On Tue, 22 Mar 2022, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > ... > > Signed-off-by: Tvrtko Ursulin > Cc: Jani Nikula > Cc: Lucas De Marchi > --- > Typed up how I see it - bash away. So is intel_vtd_active() so performance critical that it needs to be inline? We're passing struct drm

[RFC] drm/i915: Split out intel_vtd_active and run_as_guest to own header

2022-03-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin ... Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula Cc: Lucas De Marchi --- Typed up how I see it - bash away. --- drivers/gpu/drm/i915/display/intel_bw.c | 3 +- drivers/gpu/drm/i915/display/intel_display.c | 9 - drivers/gpu/drm/i915/display/intel_display.h |