[RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-07-09 Thread Inki Dae
On 2014? 07? 09? 20:06, Rahul Sharma wrote: > On 8 July 2014 21:25, Inki Dae wrote: >> 2014-06-20 0:13 GMT+09:00 Rahul Sharma : >>> This situation arises when userspace remove the frambuffer object >>> and call setmode ioctl. >>> >>> drm_mode_rmfb --> drm_plane_force_disable --> plane->crtc = NULL

[RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-07-09 Thread Rahul Sharma
On 8 July 2014 21:25, Inki Dae wrote: > 2014-06-20 0:13 GMT+09:00 Rahul Sharma : >> This situation arises when userspace remove the frambuffer object >> and call setmode ioctl. >> >> drm_mode_rmfb --> drm_plane_force_disable --> plane->crtc = NULL; >> and >> drm_mode_setcrtc --> exynos_plane_commi

[RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-07-09 Thread Inki Dae
2014-06-20 0:13 GMT+09:00 Rahul Sharma : > This situation arises when userspace remove the frambuffer object > and call setmode ioctl. > > drm_mode_rmfb --> drm_plane_force_disable --> plane->crtc = NULL; > and > drm_mode_setcrtc --> exynos_plane_commit --> passes plane->crtc to > exynos_drm_crtc_p

[RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-07-08 Thread Rahul Sharma
Hi Inki, What do you think about the following fix? I need your inputs for this. Regards, Rahul Sharma On 19 June 2014 20:43, Rahul Sharma wrote: > This situation arises when userspace remove the frambuffer object > and call setmode ioctl. > > drm_mode_rmfb --> drm_plane_force_disable --> plan

[RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-06-19 Thread Rahul Sharma
This situation arises when userspace remove the frambuffer object and call setmode ioctl. drm_mode_rmfb --> drm_plane_force_disable --> plane->crtc = NULL; and drm_mode_setcrtc --> exynos_plane_commit --> passes plane->crtc to exynos_drm_crtc_plane_commit which is NULL. This crashes the system.