[Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-10 Thread Jesse Barnes
On Thu, 6 Nov 2014 19:35:51 -0500 Rob Clark wrote: > On Thu, Nov 6, 2014 at 6:29 PM, Daniel Vetter wrote: > > > > That aside I guess I need to elaborate on what makes dpms special in > > i915, and why there's a real difference between crtc->enable == true > > && ->active == false and crtc->enabl

[RFC] dpms handling on atomic drivers

2014-11-07 Thread Daniel Vetter
On Fri, Nov 7, 2014 at 12:31 AM, Stéphane Marchesin wrote: > On Thu, Nov 6, 2014 at 1:43 AM, Daniel Vetter wrote: >> >> Hi all, >> >> After a few atomic irc chats I've shockingly realized that I've completely >> ignored dpms handling in my helper series. Oops. >> >> But there's a few things whic

[RFC] dpms handling on atomic drivers

2014-11-07 Thread Daniel Vetter
On Fri, Nov 7, 2014 at 12:33 AM, Daniel Vetter wrote: > All this only matters for cloned configs anyway only, which is about > i915 for gen2, roughly. Well Ville implemented cloning for some more > recent stuff too. Ok, I've grepped: Beside i915 there's only radeon which has a possible_clones set

[RFC] dpms handling on atomic drivers

2014-11-07 Thread Daniel Vetter
On Thu, Nov 6, 2014 at 11:35 PM, Sean Paul wrote: >>> Proposal: Only shut down anything (and then the hole output pipe with all >>> cloned outputs) when all connector's dpms property is set to off. And >>> enable it again as soon as one property goes to on. >> >> Well, it isn't quite the behavior

[RFC] dpms handling on atomic drivers

2014-11-07 Thread Daniel Vetter
>> 2. Cloned configurations >> >> Currently dpms is set per-connector, and the crtc helpers only shut down >> the specific encoder. Only when all connectors are off will it shut down >> the crtc, too. That pretty much defeats the point of the new helpers of >> always enabling/disabling a given outp

[RFC] dpms handling on atomic drivers

2014-11-06 Thread Rob Clark
On Thu, Nov 6, 2014 at 6:29 PM, Daniel Vetter wrote: >>> Proposal. Add a new boolean ->active to the crtc state, which will track >>> the dpms state of the crtc. Add a helper to the atomic core functions >>> which will compute ->active from the state update according to the >>> proposals for issue

[RFC] dpms handling on atomic drivers

2014-11-06 Thread Sean Paul
On Thu, Nov 6, 2014 at 5:06 PM, Rob Clark wrote: > On Thu, Nov 6, 2014 at 4:43 AM, Daniel Vetter wrote: >> Hi all, >> >> After a few atomic irc chats I've shockingly realized that I've completely >> ignored dpms handling in my helper series. Oops. >> >> But there's a few things which are seriousl

[RFC] dpms handling on atomic drivers

2014-11-06 Thread Rob Clark
On Thu, Nov 6, 2014 at 4:43 AM, Daniel Vetter wrote: > Hi all, > > After a few atomic irc chats I've shockingly realized that I've completely > ignored dpms handling in my helper series. Oops. > > But there's a few things which are seriously wrong with DPMS, so I've > figured I'll start a discussi

[RFC] dpms handling on atomic drivers

2014-11-06 Thread Stéphane Marchesin
On Thu, Nov 6, 2014 at 1:43 AM, Daniel Vetter wrote: > > Hi all, > > After a few atomic irc chats I've shockingly realized that I've completely > ignored dpms handling in my helper series. Oops. > > But there's a few things which are seriously wrong with DPMS, so I've > figured I'll start a discus

[RFC] dpms handling on atomic drivers

2014-11-06 Thread Daniel Vetter
Hi all, After a few atomic irc chats I've shockingly realized that I've completely ignored dpms handling in my helper series. Oops. But there's a few things which are seriously wrong with DPMS, so I've figured I'll start a discussion about them first - converting to atomic looks like a good time