[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-02 Thread Inki Dae
at vger.kernel.org; > kyungmin.park at samsung.com; linux-arm-kernel at lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > On Thu, Sep 1, 2011 at 8:06 AM, Inki Dae wrote: > >> >> > +struct samsung_drm_gem_obj * &g

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-02 Thread Kyungmin Park
; Cc: airlied at linux.ie; dri-devel at lists.freedesktop.org; >> sw0312.kim at samsung.com; linux-kernel at vger.kernel.org; >> kyungmin.park at samsung.com; linux-arm-kernel at lists.infradead.org >> Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC >> EXYNOS4210. >>

RE: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-02 Thread Inki Dae
.org; > kyungmin.p...@samsung.com; linux-arm-ker...@lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > On Thu, Sep 1, 2011 at 8:06 AM, Inki Dae wrote: > >> >> > +struct samsung_drm_gem_obj * > >> >

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Kyungmin Park
nux.ie; dri-devel@lists.freedesktop.org; >> sw0312@samsung.com; linux-ker...@vger.kernel.org; >> kyungmin.p...@samsung.com; linux-arm-ker...@lists.infradead.org >> Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC >> EXYNOS4210. >> >> On Wed,

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Inki Dae
m; linux-kernel at vger.kernel.org; > kyungmin.park at samsung.com; linux-arm-kernel at lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > On Wed, Aug 31, 2011 at 1:51 AM, Inki Dae wrote: > > Hello, Rob. > > Below is m

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Rob Clark
On Thu, Sep 1, 2011 at 8:06 AM, Inki Dae wrote: >> >> > +struct samsung_drm_gem_obj * >> >> > + ? ? ? ? ? ? ? find_samsung_drm_gem_object(struct drm_file > *file_priv, >> >> > + ? ? ? ? ? ? ? ? ? ? ? struct drm_device *dev, unsigned int handle) >> >> > +{ >> >> > + ? ? ? struct drm_gem_object *gem

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Rob Clark
On Thu, Sep 1, 2011 at 8:02 PM, Kyungmin Park wrote: >>> Just thinking hypothetically.. what if some future device had two hdmi >>> controllers. ?Then you'd want two instances of the same display >>> object. >>> >>> Although it seems this API is just internal to the DRM driver (which I >>> had not

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Rob Clark
On Thu, Sep 1, 2011 at 8:06 AM, Inki Dae wrote: >> >> > +struct samsung_drm_gem_obj * >> >> > +               find_samsung_drm_gem_object(struct drm_file > *file_priv, >> >> > +                       struct drm_device *dev, unsigned int handle) >> >> > +{ >> >> > +       struct drm_gem_object *gem

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Rob Clark
On Thu, Sep 1, 2011 at 8:02 PM, Kyungmin Park wrote: >>> Just thinking hypothetically.. what if some future device had two hdmi >>> controllers.  Then you'd want two instances of the same display >>> object. >>> >>> Although it seems this API is just internal to the DRM driver (which I >>> had not

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Inki Dae
at vger.kernel.org; > kyungmin.park at samsung.com; linux-arm-kernel at lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > On 08/26/2011 01:47 PM, Inki Dae wrote: > > This patch is a DRM Driver for Samsung SoC Exynos4210 and now enables &

RE: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-09-01 Thread Inki Dae
..@vger.kernel.org; > kyungmin.p...@samsung.com; linux-arm-ker...@lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > On Wed, Aug 31, 2011 at 1:51 AM, Inki Dae wrote: > > Hello, Rob. > > Below is my answers and questions. a

RE: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Inki Dae
gmin.p...@samsung.com; linux-arm-ker...@lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > On 08/26/2011 01:47 PM, Inki Dae wrote: > > This patch is a DRM Driver for Samsung SoC Exynos4210 and now enables > only FIMD yet &g

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Inki Dae
ts.freedesktop.org; kyungmin.park at samsung.com; linux-arm- > kernel at lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > > > + ? ? ? entry->vaddr = dma_alloc_writecombine(dev->dev, entry->size, > >

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Inki Dae
t linux.ie; dri-devel at lists.freedesktop.org; > sw0312.kim at samsung.com; linux-kernel at vger.kernel.org; > kyungmin.park at samsung.com; linux-arm-kernel at lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > Hi Inki, > >

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Joonyoung Shim
>> +static void samsung_drm_connector_destroy(struct drm_connector *connector) >> +{ >> + struct samsung_drm_connector *samsung_connector = >> + to_samsung_connector(connector); >> + >> + DRM_DEBUG_KMS("%s\n", __FILE__); >> + >> + drm_sysfs_connector_remove(connector

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Rob Clark
On Wed, Aug 31, 2011 at 1:51 AM, Inki Dae wrote: > Hello, Rob. > Below is my answers and questions. and could you please include me as CC > when you post your driver? sure thing >> > +static int samsung_drm_connector_get_modes(struct drm_connector >> *connector) >> > +{ >> > + ? ? ? struct sams

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Thomas Hellstrom
On 08/26/2011 01:47 PM, Inki Dae wrote: > This patch is a DRM Driver for Samsung SoC Exynos4210 and now enables only > FIMD yet > but we will add HDMI support also in the future. > > this patch is based on git repository below: > git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git, >

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Rob Clark
On Wed, Aug 31, 2011 at 1:51 AM, Inki Dae wrote: > Hello, Rob. > Below is my answers and questions. and could you please include me as CC > when you post your driver? sure thing >> > +static int samsung_drm_connector_get_modes(struct drm_connector >> *connector) >> > +{ >> > +       struct sams

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Thomas Hellstrom
On 08/26/2011 01:47 PM, Inki Dae wrote: This patch is a DRM Driver for Samsung SoC Exynos4210 and now enables only FIMD yet but we will add HDMI support also in the future. this patch is based on git repository below: git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git, branch nam

RE: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-31 Thread Inki Dae
op.org; kyungmin.p...@samsung.com; linux-arm- > ker...@lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > > > +       entry->vaddr = dma_alloc_writecombine(dev->dev, entry->size, > > > +    

RE: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-30 Thread Inki Dae
x.ie; dri-devel@lists.freedesktop.org; > sw0312@samsung.com; linux-ker...@vger.kernel.org; > kyungmin.p...@samsung.com; linux-arm-ker...@lists.infradead.org > Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC > EXYNOS4210. > > Hi Inki, > > Sorry for slightly

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-30 Thread Konrad Rzeszutek Wilk
> > + ? ? ? entry->vaddr = dma_alloc_writecombine(dev->dev, entry->size, > > + ? ? ? ? ? ? ? ? ? ? ? (dma_addr_t *)&entry->paddr, GFP_KERNEL); > > + ? ? ? if (!entry->paddr) { > > + ? ? ? ? ? ? ? DRM_ERROR("failed to allocate buffer.\n"); > > + ? ? ? ? ? ? ? return -ENOMEM; > > + ? ? ? } > > + > >

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-30 Thread Rob Clark
Hi Inki, Sorry for slightly overdue review.. it took a little while to go through the whole thing comments in-line below On Fri, Aug 26, 2011 at 6:47 AM, Inki Dae wrote: > This patch is a DRM Driver for Samsung SoC Exynos4210 and now enables only > FIMD yet > but we will add HDMI support also

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-30 Thread Joonyoung Shim
+static void samsung_drm_connector_destroy(struct drm_connector *connector) +{ + struct samsung_drm_connector *samsung_connector = + to_samsung_connector(connector); + + DRM_DEBUG_KMS("%s\n", __FILE__); + + drm_sysfs_connector_remove(connector); + drm_connecto

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-30 Thread Konrad Rzeszutek Wilk
> > +       entry->vaddr = dma_alloc_writecombine(dev->dev, entry->size, > > +                       (dma_addr_t *)&entry->paddr, GFP_KERNEL); > > +       if (!entry->paddr) { > > +               DRM_ERROR("failed to allocate buffer.\n"); > > +               return -ENOMEM; > > +       } > > + > >

Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-30 Thread Rob Clark
Hi Inki, Sorry for slightly overdue review.. it took a little while to go through the whole thing comments in-line below On Fri, Aug 26, 2011 at 6:47 AM, Inki Dae wrote: > This patch is a DRM Driver for Samsung SoC Exynos4210 and now enables only > FIMD yet > but we will add HDMI support also

[RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-26 Thread Inki Dae
This patch is a DRM Driver for Samsung SoC Exynos4210 and now enables only FIMD yet but we will add HDMI support also in the future. this patch is based on git repository below: git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git, branch name: drm-next commit-id: bcc65fd8e929a9d9d34