Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-04-03 Thread Robert Foss
Hey Chih-Wei, Thanks for the poke, the patch has been pushed now. Rob. On 04/03/2018 04:58 AM, Chih-Wei Huang wrote: 2018-03-28 23:22 GMT+08:00 Rob Herring : On Wed, Mar 28, 2018 at 10:19 AM, Rob Herring wrote: On Sat, Mar 17, 2018 at 2:33 PM, Stefan Schake wrote: Hey John, On Fri, Mar

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-04-02 Thread Chih-Wei Huang
2018-03-28 23:22 GMT+08:00 Rob Herring : > On Wed, Mar 28, 2018 at 10:19 AM, Rob Herring wrote: >> On Sat, Mar 17, 2018 at 2:33 PM, Stefan Schake wrote: >>> Hey John, >>> >>> On Fri, Mar 16, 2018 at 10:48 PM, John Stultz >>> wrote: In trying to integrate the new gralloc_handle.h with the >

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-28 Thread Rob Herring
On Wed, Mar 28, 2018 at 10:19 AM, Rob Herring wrote: > On Sat, Mar 17, 2018 at 2:33 PM, Stefan Schake wrote: >> Hey John, >> >> On Fri, Mar 16, 2018 at 10:48 PM, John Stultz wrote: >>> In trying to integrate the new gralloc_handle.h with the >>> drm_hwcomposer, I started seeing the following com

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-28 Thread Rob Herring
On Sat, Mar 17, 2018 at 2:33 PM, Stefan Schake wrote: > Hey John, > > On Fri, Mar 16, 2018 at 10:48 PM, John Stultz wrote: >> In trying to integrate the new gralloc_handle.h with the >> drm_hwcomposer, I started seeing the following compilation >> errors: >> >> In file included from external/drm_

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-19 Thread Robert Foss
Hey John, On 03/16/2018 10:48 PM, John Stultz wrote: In trying to integrate the new gralloc_handle.h with the drm_hwcomposer, I started seeing the following compilation errors: In file included from external/drm_hwcomposer/platformdrmgeneric.cpp:28: external/libdrm/android/gralloc_handle.h:108:

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-17 Thread Stefan Schake
Hey John, On Fri, Mar 16, 2018 at 10:48 PM, John Stultz wrote: > In trying to integrate the new gralloc_handle.h with the > drm_hwcomposer, I started seeing the following compilation > errors: > > In file included from external/drm_hwcomposer/platformdrmgeneric.cpp:28: > external/libdrm/android/g

[RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-16 Thread John Stultz
In trying to integrate the new gralloc_handle.h with the drm_hwcomposer, I started seeing the following compilation errors: In file included from external/drm_hwcomposer/platformdrmgeneric.cpp:28: external/libdrm/android/gralloc_handle.h:108:9: error: cannot initialize return object of type 'nati

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-07 Thread Robert Foss
Hey John, Yeah, the return type should be changed. robher: Do you have any preferences? Rob. On 03/06/2018 09:28 PM, John Stultz wrote: In trying to integrate the new gralloc_handle.h with the drm_hwcomposer, I started seeing the following compilation errors: In file included from external/

[RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-06 Thread John Stultz
In trying to integrate the new gralloc_handle.h with the drm_hwcomposer, I started seeing the following compilation errors: In file included from external/drm_hwcomposer/platformdrmgeneric.cpp:28: external/libdrm/android/gralloc_handle.h:108:9: error: cannot initialize return object of type 'nati