Re: [RFC][PATCH] drm: i915: do not NULL deref hdmi attached_connector

2024-11-14 Thread Sergey Senozhatsky
On (24/11/14 17:53), Jani Nikula wrote: > > Ville, we handle intel_ddi_init_dp_connector() failures but not > > intel_ddi_init_hdmi_connector() failures. Do you recall if there's a > > reason for that? Something like a dual-mode port where DP works but HDMI > > gets rejected because of bogus VBT in

Re: [RFC][PATCH] drm: i915: do not NULL deref hdmi attached_connector

2024-11-14 Thread Jani Nikula
On Wed, 13 Nov 2024, Jani Nikula wrote: > On Wed, 13 Nov 2024, Sergey Senozhatsky wrote: >> On (24/10/31 19:51), Sergey Senozhatsky wrote: >>> intel_ddi_init() may skip connector initialization, for instance, >>> both intel_ddi_init_dp_connector() and intel_ddi_init_hdmi_connector() >>> are optio

Re: [RFC][PATCH] drm: i915: do not NULL deref hdmi attached_connector

2024-11-13 Thread Jani Nikula
On Wed, 13 Nov 2024, Sergey Senozhatsky wrote: > On (24/10/31 19:51), Sergey Senozhatsky wrote: >> intel_ddi_init() may skip connector initialization, for instance, >> both intel_ddi_init_dp_connector() and intel_ddi_init_hdmi_connector() >> are optional. This leads to situation that ->attached_c

Re: [RFC][PATCH] drm: i915: do not NULL deref hdmi attached_connector

2024-11-13 Thread Sergey Senozhatsky
On (24/10/31 19:51), Sergey Senozhatsky wrote: > intel_ddi_init() may skip connector initialization, for instance, > both intel_ddi_init_dp_connector() and intel_ddi_init_hdmi_connector() > are optional. This leads to situation that ->attached_connector may > be NULL for some connectors. For inst

Re: [RFC][PATCH] drm: i915: do not NULL deref hdmi attached_connector

2024-10-31 Thread Sergey Senozhatsky
On (24/10/31 13:33), Jani Nikula wrote: > > intel_ddi_init() may skip connector initialization, for instance, > > both intel_ddi_init_dp_connector() and intel_ddi_init_hdmi_connector() > > are optional. This leads to situation that ->attached_connector may > > be NULL for some connectors. For ins

Re: [RFC][PATCH] drm: i915: do not NULL deref hdmi attached_connector

2024-10-31 Thread Jani Nikula
On Thu, 31 Oct 2024, Sergey Senozhatsky wrote: > *** RFC *** > > intel_ddi_init() may skip connector initialization, for instance, > both intel_ddi_init_dp_connector() and intel_ddi_init_hdmi_connector() > are optional. This leads to situation that ->attached_connector may > be NULL for som

[RFC][PATCH] drm: i915: do not NULL deref hdmi attached_connector

2024-10-31 Thread Sergey Senozhatsky
*** RFC *** intel_ddi_init() may skip connector initialization, for instance, both intel_ddi_init_dp_connector() and intel_ddi_init_hdmi_connector() are optional. This leads to situation that ->attached_connector may be NULL for some connectors. For instance, on my setup 'DDI A/PHY A' an