Re: [RFC][PATCH] drm: bridge: dw-mipi-dsi: Call modeset in modeset callback

2024-04-21 Thread Ondřej Jirman
On Sun, Apr 21, 2024 at 04:25:34PM GMT, Marek Vasut wrote: > On 4/21/24 1:09 PM, Ondřej Jirman wrote: > > Hi, > > Hi, > > > On Sun, Apr 21, 2024 at 02:22:35AM GMT, Marek Vasut wrote: > > > Doing modeset in .atomic_pre_enable callback instead of dedicated > > > .mode_set > > > callback does not s

Re: [RFC][PATCH] drm: bridge: dw-mipi-dsi: Call modeset in modeset callback

2024-04-21 Thread Marek Vasut
On 4/21/24 1:09 PM, Ondřej Jirman wrote: Hi, Hi, On Sun, Apr 21, 2024 at 02:22:35AM GMT, Marek Vasut wrote: Doing modeset in .atomic_pre_enable callback instead of dedicated .mode_set callback does not seem right. Undo this change, which was added as part of Actually no. If anything, mode_

Re: [RFC][PATCH] drm: bridge: dw-mipi-dsi: Call modeset in modeset callback

2024-04-21 Thread Ondřej Jirman
Hi, On Sun, Apr 21, 2024 at 02:22:35AM GMT, Marek Vasut wrote: > Doing modeset in .atomic_pre_enable callback instead of dedicated .mode_set > callback does not seem right. Undo this change, which was added as part of Actually no. If anything, mode_set callback should be dropped entirely: See ht

[RFC][PATCH] drm: bridge: dw-mipi-dsi: Call modeset in modeset callback

2024-04-20 Thread Marek Vasut
Doing modeset in .atomic_pre_enable callback instead of dedicated .mode_set callback does not seem right. Undo this change, which was added as part of commit 05aa61334592 ("drm: bridge: dw-mipi-dsi: Fix enable/disable of DSI controller") as it breaks STM32MP15xx LTDC scanout (DSI)->TC358762 DSI-to-